2023-07-18 18:09:03

by Jiaqing Zhao

[permalink] [raw]
Subject: [PATCH 0/4] add support for ASIX AX99100

This patch adds kernel inbox driver support for the serial port and
parallel port mode controller of ASIX AX99100 PCIe to Multi I/O
Controller. This device has 4 separate PCI functions and each functions
can be configured to operate in different modes.

This patchset is tested with ASIX AX99100 in following modes:
* 4 x Serial Port
* 2 x Serial Port
* 2 x Serial Port + 1 x Parallel Port
* 1 x Parallel Port

Jiaqing Zhao (4):
can: ems_pci: remove PCI_SUBVENDOR_ID_ASIX definition
can: ems_pci: move ASIX AX99100 ids to pci_ids.h
serial: 8250_pci: add support for ASIX AX99100
parport_pc: add support for ASIX AX99100

drivers/net/can/sja1000/ems_pci.c | 7 +------
drivers/parport/parport_pc.c | 5 +++++
drivers/tty/serial/8250/8250_pci.c | 10 ++++++++++
include/linux/pci_ids.h | 4 ++++
4 files changed, 20 insertions(+), 6 deletions(-)

--
2.39.2



2023-07-18 18:11:08

by Jiaqing Zhao

[permalink] [raw]
Subject: [PATCH 3/4] serial: 8250_pci: add support for ASIX AX99100

All 4 PCI functions on ASIX AX99100 PCIe to Multi I/O Controller can be
configured as a single-port serial port controller. The subvendor id is
0x1000 when configured as serial port and MSI interrupts are supported.

Signed-off-by: Jiaqing Zhao <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/tty/serial/8250/8250_pci.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index d2d547b5da95..62a9bd30b4db 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -67,6 +67,8 @@ static const struct pci_device_id pci_use_msi[] = {
0xA000, 0x1000) },
{ PCI_DEVICE_SUB(PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9922,
0xA000, 0x1000) },
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_ASIX, PCI_DEVICE_ID_ASIX_AX99100,
+ 0xA000, 0x1000) },
{ PCI_DEVICE_SUB(PCI_VENDOR_ID_HP_3PAR, PCI_DEVICE_ID_HPE_PCI_SERIAL,
PCI_ANY_ID, PCI_ANY_ID) },
{ }
@@ -5557,6 +5559,14 @@ static const struct pci_device_id serial_pci_tbl[] = {
{ PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9865,
0xA000, 0x3004,
0, 0, pbn_b0_bt_4_115200 },
+
+ /*
+ * ASIX AX99100 PCIe to Multi I/O Controller
+ */
+ { PCI_VENDOR_ID_ASIX, PCI_DEVICE_ID_ASIX_AX99100,
+ 0xA000, 0x1000,
+ 0, 0, pbn_b0_1_115200 },
+
/* Intel CE4100 */
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_CE4100_UART,
PCI_ANY_ID, PCI_ANY_ID, 0, 0,
--
2.39.2


2023-07-18 19:00:09

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH 3/4] serial: 8250_pci: add support for ASIX AX99100

On Tue, Jul 18, 2023 at 05:41:59PM +0000, Jiaqing Zhao wrote:
> All 4 PCI functions on ASIX AX99100 PCIe to Multi I/O Controller can be

Maybe clearer to say "Each of the four PCI functions ... can be
configured as a serial port controller"?

> configured as a single-port serial port controller. The subvendor id is
> 0x1000 when configured as serial port and MSI interrupts are supported.

2023-07-20 09:40:27

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH 0/4] add support for ASIX AX99100

On 18.07.2023 17:41:56, Jiaqing Zhao wrote:
> This patch adds kernel inbox driver support for the serial port and
> parallel port mode controller of ASIX AX99100 PCIe to Multi I/O
> Controller. This device has 4 separate PCI functions and each functions
> can be configured to operate in different modes.
>
> This patchset is tested with ASIX AX99100 in following modes:
> * 4 x Serial Port
> * 2 x Serial Port
> * 2 x Serial Port + 1 x Parallel Port
> * 1 x Parallel Port

I think it's better to split the series into subsystems. For CAN that
would be patches 1 and 2. Please add [email protected] and
[email protected] on Cc.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (948.00 B)
signature.asc (499.00 B)
Download all attachments