2023-07-19 10:17:03

by Andrei Coardos

Subject: [PATCH] gpio: exar: remove unneeded platform_set_drvdata() call

The platform_set_drvdata() was needed when the driver had an explicit
remove function.
That function got removed a while back, so we don't need to keep a pointer
(on 'dev->driver_data') for the private data of the driver anymore.

Reviewed-by: Alexandru Ardelean <[email protected]>
Signed-off-by: Andrei Coardos <[email protected]>
---
drivers/gpio/gpio-exar.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
index df1bdaae441c..5170fe7599cd 100644
--- a/drivers/gpio/gpio-exar.c
+++ b/drivers/gpio/gpio-exar.c
@@ -217,8 +217,6 @@ static int gpio_exar_probe(struct platform_device *pdev)
if (ret)
return ret;

- platform_set_drvdata(pdev, exar_gpio);
-
return 0;
}

--
2.34.1

2023-07-19 15:38:10

by Andy Shevchenko

Subject: Re: [PATCH] gpio: exar: remove unneeded platform_set_drvdata() call

On Wed, Jul 19, 2023 at 12:39:23PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() was needed when the driver had an explicit
> remove function.
> That function got removed a while back, so we don't need to keep a pointer
> (on 'dev->driver_data') for the private data of the driver anymore.

Reviewed-by: Andy Shevchenko <[email protected]>

--
With Best Regards,
Andy Shevchenko

2023-07-29 14:31:31

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: exar: remove unneeded platform_set_drvdata() call

On Wed, Jul 19, 2023 at 11:41 AM Andrei Coardos <[email protected]> wrote:
>
> The platform_set_drvdata() was needed when the driver had an explicit
> remove function.
> That function got removed a while back, so we don't need to keep a pointer
> (on 'dev->driver_data') for the private data of the driver anymore.
>
> Reviewed-by: Alexandru Ardelean <[email protected]>
> Signed-off-by: Andrei Coardos <[email protected]>
> ---
> drivers/gpio/gpio-exar.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c
> index df1bdaae441c..5170fe7599cd 100644
> --- a/drivers/gpio/gpio-exar.c
> +++ b/drivers/gpio/gpio-exar.c
> @@ -217,8 +217,6 @@ static int gpio_exar_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - platform_set_drvdata(pdev, exar_gpio);
> -
> return 0;
> }
>
> --
> 2.34.1
>

Applied, thanks!

Bart