2023-07-19 15:01:27

by Martijn Braam

Subject: [PATCH] media: rkisp1: Promote link validation error to dev_err

Show an error when the pipeline cannot start due to an invalid link
instead of hiding it behind the debugging system.

Signed-off-by: Martijn Braam <[email protected]>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
index 8f3cba319762..9361b9086f6b 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
@@ -1340,7 +1340,7 @@ static int rkisp1_capture_link_validate(struct media_link *link)
if (sd_fmt.format.height != cap->pix.fmt.height ||
sd_fmt.format.width != cap->pix.fmt.width ||
sd_fmt.format.code != fmt->mbus) {
- dev_dbg(cap->rkisp1->dev,
+ dev_err(cap->rkisp1->dev,
"link '%s':%u -> '%s':%u not valid: 0x%04x/%ux%u != 0x%04x/%ux%u\n",
link->source->entity->name, link->source->index,
link->sink->entity->name, link->sink->index,
--
2.40.0

2023-09-22 20:21:44

by Laurent Pinchart

Subject: Re: [PATCH] media: rkisp1: Promote link validation error to dev_err

Hi Martijn,

Thank you for the patch.

On Wed, Jul 19, 2023 at 04:55:33PM +0200, Martijn Braam wrote:
> Show an error when the pipeline cannot start due to an invalid link
> instead of hiding it behind the debugging system.

While this can help debugging issues in applications, allowing
unpriviledged applications to control messages being printed to the
kernel log is frowned upon, is it could flood the log. This is why these
messages use dev_dbg() and not dev_err().

> Signed-off-by: Martijn Braam <[email protected]>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> index 8f3cba319762..9361b9086f6b 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c
> @@ -1340,7 +1340,7 @@ static int rkisp1_capture_link_validate(struct media_link *link)
> if (sd_fmt.format.height != cap->pix.fmt.height ||
> sd_fmt.format.width != cap->pix.fmt.width ||
> sd_fmt.format.code != fmt->mbus) {
> - dev_dbg(cap->rkisp1->dev,
> + dev_err(cap->rkisp1->dev,
> "link '%s':%u -> '%s':%u not valid: 0x%04x/%ux%u != 0x%04x/%ux%u\n",
> link->source->entity->name, link->source->index,
> link->sink->entity->name, link->sink->index,

--
Regards,

Laurent Pinchart