Hi all,
After merging the bluetooth tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
Caused by commit
817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell
Hi all,
On Tue, 13 Jun 2023 13:02:58 +1000 Stephen Rothwell <[email protected]> wrote:
>
After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
>
> Caused by commit
>
> 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
>
> I have reverted that commit for today.
I am still reverting that commit.
--
Cheers,
Stephen Rothwell
Hi Luiz,
On Thu, 15 Jun 2023 23:06:59 +0000 "Von Dentz, Luiz" <[email protected]> wrote:
>
> Im on bussiness trip this week thus the delay, will be back next week
> so I hope this can wait until then.
No worries, just checking that it wasn't forgotten.
--
Cheers,
Stephen Rothwell
On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz
<[email protected]> wrote:
>
> Hi Stephen, Alexander,
Dear friends,
>
> Looks like we have a similar problem as to:
>
> https://lore.kernel.org/lkml/[email protected]/
>
> That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw).
Ugh, yep. That's bad and we can't workaround it like we did for unix sockets.
Originally, Christian had objections against exporting the
pidfd_prepare function [1]
[1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/
+cc Christian
Kind regards,
Alex
>
>
> ________________________________ From: Stephen Rothwell
> Sent: Monday, June 12, 2023 8:02 PM
> To: Marcel Holtmann; Johan Hedberg
> Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: linux-next: build failure after merge of the bluetooth tree
>
> Hi all,
>
> After merging the bluetooth tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
>
> Caused by commit
>
> 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell
On Fri, Jun 23, 2023 at 10:34 AM Alexander Mikhalitsyn
<[email protected]> wrote:
>
> On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz
> <[email protected]> wrote:
> >
> > Hi Stephen, Alexander,
>
> Dear friends,
>
> >
> > Looks like we have a similar problem as to:
> >
> > https://lore.kernel.org/lkml/[email protected]/
> >
> > That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw).
>
> Ugh, yep. That's bad and we can't workaround it like we did for unix sockets.
>
> Originally, Christian had objections against exporting the
> pidfd_prepare function [1]
>
> [1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/
>
> +cc Christian
Idea. (-: We can introduce a new function like "scm_recv_light" that
will be just an old version of "scm_recv" without using pidfd,
if this feature with SCM_PIDFD is not important for hci sockets.
Forgot to add Jakub to CC.
+cc Jakub
>
> Kind regards,
> Alex
>
> >
> >
> > ________________________________ From: Stephen Rothwell
> > Sent: Monday, June 12, 2023 8:02 PM
> > To: Marcel Holtmann; Johan Hedberg
> > Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> > Subject: linux-next: build failure after merge of the bluetooth tree
> >
> > Hi all,
> >
> > After merging the bluetooth tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
> >
> > Caused by commit
> >
> > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
> >
> > I have reverted that commit for today.
> >
> > --
> > Cheers,
> > Stephen Rothwell
On Fri, Jun 23, 2023 at 2:24 PM Christian Brauner <[email protected]> wrote:
>
> On Fri, Jun 23, 2023 at 11:23:57AM +0200, Alexander Mikhalitsyn wrote:
> > On Fri, Jun 23, 2023 at 10:34 AM Alexander Mikhalitsyn
> > <[email protected]> wrote:
> > >
> > > On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz
> > > <[email protected]> wrote:
> > > >
> > > > Hi Stephen, Alexander,
> > >
> > > Dear friends,
> > >
> > > >
> > > > Looks like we have a similar problem as to:
> > > >
> > > > https://lore.kernel.org/lkml/[email protected]/
> > > >
> > > > That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw).
> > >
> > > Ugh, yep. That's bad and we can't workaround it like we did for unix sockets.
> > >
> > > Originally, Christian had objections against exporting the
> > > pidfd_prepare function [1]
> > >
> > > [1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/
> > >
> > > +cc Christian
> >
> > Idea. (-: We can introduce a new function like "scm_recv_light" that
>
> Seems fine to me.
Thanks, Christian!
Let's wait for Jakub's comment then :) Then I'll prepare and send a patch.
Kind regards,
Alex
On Fri, Jun 23, 2023 at 11:23:57AM +0200, Alexander Mikhalitsyn wrote:
> On Fri, Jun 23, 2023 at 10:34 AM Alexander Mikhalitsyn
> <[email protected]> wrote:
> >
> > On Fri, Jun 23, 2023 at 12:28 AM Von Dentz, Luiz
> > <[email protected]> wrote:
> > >
> > > Hi Stephen, Alexander,
> >
> > Dear friends,
> >
> > >
> > > Looks like we have a similar problem as to:
> > >
> > > https://lore.kernel.org/lkml/[email protected]/
> > >
> > > That said for unix socket it was decided to not allow it to be build as module, which is something I don't think we are willing to do for bluetooth, so we have to find a way to get around pidfd_prepare, which seems to be called due to the use of scm_recv (it is also used by netlink btw).
> >
> > Ugh, yep. That's bad and we can't workaround it like we did for unix sockets.
> >
> > Originally, Christian had objections against exporting the
> > pidfd_prepare function [1]
> >
> > [1] https://lore.kernel.org/all/20230523-flechten-ortsschild-e5724ecc4ed0@brauner/
> >
> > +cc Christian
>
> Idea. (-: We can introduce a new function like "scm_recv_light" that
Seems fine to me.
On Fri, 23 Jun 2023 14:28:06 +0200 Alexander Mikhalitsyn wrote:
> > Seems fine to me.
>
> Thanks, Christian!
>
> Let's wait for Jakub's comment then :) Then I'll prepare and send a patch.
????️ sounds good to me as well
On Fri, Jun 23, 2023 at 5:09 PM Jakub Kicinski <[email protected]> wrote:
>
> On Fri, 23 Jun 2023 14:28:06 +0200 Alexander Mikhalitsyn wrote:
> > > Seems fine to me.
> >
> > Thanks, Christian!
> >
> > Let's wait for Jakub's comment then :) Then I'll prepare and send a patch.
>
> ????️ sounds good to me as well
Dear colleagues,
I've sent a patch
https://lore.kernel.org/netdev/[email protected]
Kind regards,
Alex
Hi all,
On Fri, 16 Jun 2023 08:32:37 +1000 Stephen Rothwell <[email protected]> wrote:
>
> On Tue, 13 Jun 2023 13:02:58 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> After merging the bluetooth tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
> >
> > Caused by commit
> >
> > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
> >
> > I have reverted that commit for today.
>
> I am still reverting that commit.
Ditto
--
Cheers,
Stephen Rothwell
On Thu, 20 Jul 2023 10:50:42 +1000 Stephen Rothwell wrote:
> Hi all,
>
> On Sat, 8 Jul 2023 00:17:15 +0000 "Von Dentz, Luiz" <[email protected]> wrote:
> >
> > There was a patch sent to net-next that was supposed to fix this:
> >
> > [PATCH v1 net-next 2/2] net: scm: introduce and use scm_recv_unix helper
> >
> > I am waiting for it to be merged.
> >
> >
> > ________________________________
> > From: Stephen Rothwell
> > Sent: Thursday, July 6, 2023 4:41 PM
> > To: Marcel Holtmann; Johan Hedberg
> > Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> > Subject: Re: linux-next: build failure after merge of the bluetooth tree
> >
> > Hi all,
> >
> > On Fri, 16 Jun 2023 08:32:37 +1000 Stephen Rothwell <[email protected]> wrote:
> > >
> > > On Tue, 13 Jun 2023 13:02:58 +1000 Stephen Rothwell <[email protected]> wrote:
> > > >
> > > After merging the bluetooth tree, today's linux-next build (arm
> > > > multi_v7_defconfig) failed like this:
> > > >
> > > > ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
> > > >
> > > > Caused by commit
> > > >
> > > > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
> > > >
> > > > I have reverted that commit for today.
> > >
> > > I am still reverting that commit.
> >
> > Ditto
>
> This is getting a bit ridiculous ... a build failure reported over a
> month ago with a fix
> (https://lore.kernel.org/netdev/[email protected])
> posted 3 weeks ago, has not yet been fixed :-(
>
> What is stopping that fix (with the appropriate followup) being added
> to the bluetooth tree? Or just the fix being added to the net-next tree?
>
> Yes, I know that the time period includes the merge window, but it has
> been more that a week since then.
Something weird. We did merge it, there was a sort-of-v2-called-v1:
https://lore.kernel.org/all/[email protected]/
Merged as https://git.kernel.org/netdev/net-next/c/a9c49cc2f5b5
Dunno how it's supposed to fix this particular issue, tho, on a closer
look, as it still calls:
scm_recv_unix() -> scm_pidfd_recv() -> pidfd_prepare()
:S
Hi all,
On Sat, 8 Jul 2023 00:17:15 +0000 "Von Dentz, Luiz" <[email protected]> wrote:
>
> There was a patch sent to net-next that was supposed to fix this:
>
> [PATCH v1 net-next 2/2] net: scm: introduce and use scm_recv_unix helper
>
> I am waiting for it to be merged.
>
>
> ________________________________
> From: Stephen Rothwell
> Sent: Thursday, July 6, 2023 4:41 PM
> To: Marcel Holtmann; Johan Hedberg
> Cc: Von Dentz, Luiz; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: Re: linux-next: build failure after merge of the bluetooth tree
>
> Hi all,
>
> On Fri, 16 Jun 2023 08:32:37 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > On Tue, 13 Jun 2023 13:02:58 +1000 Stephen Rothwell <[email protected]> wrote:
> > >
> > After merging the bluetooth tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > >
> > > ERROR: modpost: "pidfd_prepare" [net/bluetooth/bluetooth.ko] undefined!
> > >
> > > Caused by commit
> > >
> > > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
> > >
> > > I have reverted that commit for today.
> >
> > I am still reverting that commit.
>
> Ditto
This is getting a bit ridiculous ... a build failure reported over a
month ago with a fix
(https://lore.kernel.org/netdev/[email protected])
posted 3 weeks ago, has not yet been fixed :-(
What is stopping that fix (with the appropriate followup) being added
to the bluetooth tree? Or just the fix being added to the net-next tree?
Yes, I know that the time period includes the merge window, but it has
been more that a week since then.
--
Cheers,
Stephen Rothwell
Hi Jakub,
On Wed, 19 Jul 2023 18:24:39 -0700 Jakub Kicinski <[email protected]> wrote:
>
> Something weird. We did merge it, there was a sort-of-v2-called-v1:
>
> https://lore.kernel.org/all/[email protected]/
>
> Merged as https://git.kernel.org/netdev/net-next/c/a9c49cc2f5b5
That is not the net-next tree in linux-next. I have always used
git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git#main.
And the above commit is not in linux-next (yet?)
> Dunno how it's supposed to fix this particular issue, tho, on a closer
> look, as it still calls:
>
> scm_recv_unix() -> scm_pidfd_recv() -> pidfd_prepare()
Yeah, the bluetooth tree will need to change that after the above patch
is available to it.
--
Cheers,
Stephen Rothwell
On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> Sorry for not replying inline, outlook on android, we use scm_recv
> not scm_recv_unix, so Id assume that change would return the initial
> behavior, if it did not then it is not fixing anything.
Ack, that's what it seems like to me as well.
I fired up an allmodconfig build of linux-next. I should be able
to get to the bottom of this in ~20min :)
On Thu, Jul 20, 2023 at 5:24 AM Jakub Kicinski <[email protected]> wrote:
>
> On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> > Sorry for not replying inline, outlook on android, we use scm_recv
> > not scm_recv_unix, so Id assume that change would return the initial
> > behavior, if it did not then it is not fixing anything.
>
> Ack, that's what it seems like to me as well.
>
> I fired up an allmodconfig build of linux-next. I should be able
> to get to the bottom of this in ~20min :)
Dear friends,
I'm here and ready to help with fixing this. As far as I understand
everything should work,
because in 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
we have a call to scm_recv(sock, msg, &scm, flags). And scm_recv does
not use scm_pidfd_recv (and pidfd_prepare).
Please tell me if something is not working and which tree I should
take to reproduce it. I'm ready to dive into it.
Kind regards,
Alex
On Thu, Jul 20, 2023 at 5:14 PM Jakub Kicinski <[email protected]> wrote:
>
> On Wed, 19 Jul 2023 20:24:35 -0700 Jakub Kicinski wrote:
> > On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> > > Sorry for not replying inline, outlook on android, we use scm_recv
> > > not scm_recv_unix, so Id assume that change would return the initial
> > > behavior, if it did not then it is not fixing anything.
> >
> > Ack, that's what it seems like to me as well.
> >
> > I fired up an allmodconfig build of linux-next. I should be able
> > to get to the bottom of this in ~20min :)
>
> I kicked it off and forgot about it.
> allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
Dear Jakub,
Thanks for checking!
As I can see linux-next tree contains both patches:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?h=next-20230719&qt=grep&q=Forward+credentials+to+monitor
So, the fix is working, right?
Kind regards,
Alex
On Wed, 19 Jul 2023 20:24:35 -0700 Jakub Kicinski wrote:
> On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> > Sorry for not replying inline, outlook on android, we use scm_recv
> > not scm_recv_unix, so Id assume that change would return the initial
> > behavior, if it did not then it is not fixing anything.
>
> Ack, that's what it seems like to me as well.
>
> I fired up an allmodconfig build of linux-next. I should be able
> to get to the bottom of this in ~20min :)
I kicked it off and forgot about it.
allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
Hi Jakub,
On Thu, 20 Jul 2023 08:14:30 -0700 Jakub Kicinski <[email protected]> wrote:
>
> On Wed, 19 Jul 2023 20:24:35 -0700 Jakub Kicinski wrote:
> > On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> > > Sorry for not replying inline, outlook on android, we use scm_recv
> > > not scm_recv_unix, so Id assume that change would return the initial
> > > behavior, if it did not then it is not fixing anything.
> >
> > Ack, that's what it seems like to me as well.
> >
> > I fired up an allmodconfig build of linux-next. I should be able
> > to get to the bottom of this in ~20min :)
>
> I kicked it off and forgot about it.
> allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
Of course it does, as commit
817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
is reverted in linux-next. The question is "Does the bluetooth tree
build?" or "Does the net-next tree build *if* you merge the bluetooth
tree into it?"
--
Cheers,
Stephen Rothwell
Hi Alexander,
On Thu, 20 Jul 2023 17:21:54 +0200 Alexander Mikhalitsyn <[email protected]> wrote:
>
> On Thu, Jul 20, 2023 at 5:14 PM Jakub Kicinski <[email protected]> wrote:
> >
> > On Wed, 19 Jul 2023 20:24:35 -0700 Jakub Kicinski wrote:
> > > On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> > > > Sorry for not replying inline, outlook on android, we use scm_recv
> > > > not scm_recv_unix, so Id assume that change would return the initial
> > > > behavior, if it did not then it is not fixing anything.
> > >
> > > Ack, that's what it seems like to me as well.
> > >
> > > I fired up an allmodconfig build of linux-next. I should be able
> > > to get to the bottom of this in ~20min :)
> >
> > I kicked it off and forgot about it.
> > allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
>
> Thanks for checking!
>
> As I can see linux-next tree contains both patches:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/?h=next-20230719&qt=grep&q=Forward+credentials+to+monitor
>
> So, the fix is working, right?
I will remove the revert today.
Thanks.
--
Cheers,
Stephen Rothwell
From: Stephen Rothwell <[email protected]>
Date: Fri, 21 Jul 2023 08:12:58 +1000
> Hi Jakub,
>
> On Thu, 20 Jul 2023 08:14:30 -0700 Jakub Kicinski <[email protected]> wrote:
> >
> > On Wed, 19 Jul 2023 20:24:35 -0700 Jakub Kicinski wrote:
> > > On Thu, 20 Jul 2023 03:17:37 +0000 Von Dentz, Luiz wrote:
> > > > Sorry for not replying inline, outlook on android, we use scm_recv
> > > > not scm_recv_unix, so Id assume that change would return the initial
> > > > behavior, if it did not then it is not fixing anything.
> > >
> > > Ack, that's what it seems like to me as well.
> > >
> > > I fired up an allmodconfig build of linux-next. I should be able
> > > to get to the bottom of this in ~20min :)
> >
> > I kicked it off and forgot about it.
> > allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
>
> Of course it does, as commit
>
> 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
>
> is reverted in linux-next. The question is "Does the bluetooth tree
> build?" or "Does the net-next tree build *if* you merge the bluetooth
> tree into it?"
FWIW, I was able to built net-next with the commit yesterday.
---8<---
$ grep CONFIG_BT .config
CONFIG_BT=m
CONFIG_BT_BREDR=y
CONFIG_BT_RFCOMM=m
CONFIG_BT_RFCOMM_TTY=y
CONFIG_BT_BNEP=m
CONFIG_BT_BNEP_MC_FILTER=y
CONFIG_BT_BNEP_PROTO_FILTER=y
CONFIG_BT_HIDP=m
CONFIG_BT_HS=y
CONFIG_BT_LE=y
CONFIG_BT_LE_L2CAP_ECRED=y
CONFIG_BT_LEDS=y
CONFIG_BT_MSFTEXT=y
CONFIG_BT_AOSPEXT=y
CONFIG_BT_DEBUGFS=y
CONFIG_BT_SELFTEST=y
CONFIG_BT_SELFTEST_ECDH=y
CONFIG_BT_SELFTEST_SMP=y
CONFIG_BT_FEATURE_DEBUG=y
CONFIG_BT_INTEL=m
CONFIG_BT_BCM=m
CONFIG_BT_RTL=m
CONFIG_BT_MTK=m
CONFIG_BT_HCIBTUSB=m
CONFIG_BT_HCIBTUSB_AUTOSUSPEND=y
CONFIG_BT_HCIBTUSB_POLL_SYNC=y
CONFIG_BT_HCIBTUSB_BCM=y
CONFIG_BT_HCIBTUSB_MTK=y
CONFIG_BT_HCIBTUSB_RTL=y
CONFIG_BT_HCIUART=m
CONFIG_BT_HCIUART_H4=y
CONFIG_BT_HCIUART_BCSP=y
CONFIG_BT_HCIUART_ATH3K=y
CONFIG_BT_HCIUART_AG6XX=y
CONFIG_BT_HCIBCM203X=m
CONFIG_BT_HCIBCM4377=m
CONFIG_BT_HCIBPA10X=m
CONFIG_BT_HCIBFUSB=m
CONFIG_BT_HCIDTL1=m
CONFIG_BT_HCIBT3C=m
CONFIG_BT_HCIBLUECARD=m
CONFIG_BT_HCIVHCI=m
CONFIG_BT_MRVL=m
CONFIG_BT_ATH3K=m
CONFIG_BT_VIRTIO=m
---8<---
On Fri, 21 Jul 2023 08:12:58 +1000 Stephen Rothwell wrote:
> > I kicked it off and forgot about it.
> > allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
>
> Of course it does, as commit
>
> 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
>
> is reverted in linux-next. The question is "Does the bluetooth tree
> build?" or "Does the net-next tree build *if* you merge the bluetooth
> tree into it?"
Sorry for being slow, yes. I just did a test build with net-next and
bluetooth-next combined and allmodconfig is okay, so you should be good
to drop the revert. Fingers crossed.
Hi Jakub,
On Thu, 20 Jul 2023 16:27:56 -0700 Jakub Kicinski <[email protected]> wrote:
>
> On Fri, 21 Jul 2023 08:12:58 +1000 Stephen Rothwell wrote:
> > > I kicked it off and forgot about it.
> > > allmodconfig on 352ce39a8bbaec04 (next-20230719) builds just fine :S
> >
> > Of course it does, as commit
> >
> > 817efd3cad74 ("Bluetooth: hci_sock: Forward credentials to monitor")
> >
> > is reverted in linux-next. The question is "Does the bluetooth tree
> > build?" or "Does the net-next tree build *if* you merge the bluetooth
> > tree into it?"
>
> Sorry for being slow, yes. I just did a test build with net-next and
> bluetooth-next combined and allmodconfig is okay, so you should be good
> to drop the revert. Fingers crossed.
Excellent, thanks.
--
Cheers,
Stephen Rothwell