Hi!
The series adds support for PECI on Nuvoton-based BMC boards.
It is based on patches that were sent by Tomer Maimon from
Nuvoton [1].
Similar to Aspeed driver, unused (as in, default values were used in
all of the available DTS files) vendor-specific properties were
removed.
If there is a use-case for such properties, they can be added in
a separate series.
Thank you Tomer for testing this series on Nuvoton hardware.
Thanks
-Iwona
[1] https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/
Iwona Winiarska (2):
ARM: dts: nuvoton: Add PECI controller node
arm64: dts: nuvoton: Add PECI controller node
Tomer Maimon (2):
dt-bindings: Add bindings for peci-npcm
peci: Add peci-npcm controller driver
.../devicetree/bindings/peci/peci-npcm.yaml | 56 ++++
.../dts/nuvoton/nuvoton-common-npcm7xx.dtsi | 9 +
.../dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 9 +
drivers/peci/controller/Kconfig | 16 +
drivers/peci/controller/Makefile | 1 +
drivers/peci/controller/peci-npcm.c | 298 ++++++++++++++++++
6 files changed, 389 insertions(+)
create mode 100644 Documentation/devicetree/bindings/peci/peci-npcm.yaml
create mode 100644 drivers/peci/controller/peci-npcm.c
--
2.40.1
Add PECI controller node with all required information.
Signed-off-by: Iwona Winiarska <[email protected]>
---
arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index aa7aac8c3774..b8326bbe9fde 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -68,6 +68,15 @@ apb {
ranges = <0x0 0x0 0xf0000000 0x00300000>,
<0xfff00000 0x0 0xfff00000 0x00016000>;
+ peci0: peci-controller@100000 {
+ compatible = "nuvoton,npcm845-peci";
+ reg = <0x100000 0x1000>;
+ interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk NPCM8XX_CLK_APB3>;
+ cmd-timeout-ms = <1000>;
+ status = "disabled";
+ };
+
timer0: timer@8000 {
compatible = "nuvoton,npcm845-timer";
interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
--
2.40.1
On 20/07/2023 00:08, Iwona Winiarska wrote:
> Hi!
>
> The series adds support for PECI on Nuvoton-based BMC boards.
> It is based on patches that were sent by Tomer Maimon from
> Nuvoton [1].
> Similar to Aspeed driver, unused (as in, default values were used in
> all of the available DTS files) vendor-specific properties were
> removed.
> If there is a use-case for such properties, they can be added in
> a separate series.
>
> Thank you Tomer for testing this series on Nuvoton hardware.
>
> Thanks
> -Iwona
>
> [1] https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/
>
This is not v1 but v3 or v4. Please provide proper changelog and versioning.
Best regards,
Krzysztof
On Thu, 2023-07-20 at 08:17 +0200, Krzysztof Kozlowski wrote:
> On 20/07/2023 00:08, Iwona Winiarska wrote:
> > Hi!
> >
> > The series adds support for PECI on Nuvoton-based BMC boards.
> > It is based on patches that were sent by Tomer Maimon from
> > Nuvoton [1].
> > Similar to Aspeed driver, unused (as in, default values were used in
> > all of the available DTS files) vendor-specific properties were
> > removed.
> > If there is a use-case for such properties, they can be added in
> > a separate series.
> >
> > Thank you Tomer for testing this series on Nuvoton hardware.
> >
> > Thanks
> > -Iwona
> >
> > [1]
> > https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/
> >
>
> This is not v1 but v3 or v4. Please provide proper changelog and versioning.
This is the first submission - also known as v1 :)
Could you elaborate on why do you believe that this is v3 or v4?
-Iwona
>
> Best regards,
> Krzysztof
>
On 20/07/2023 10:00, Winiarska, Iwona wrote:
> On Thu, 2023-07-20 at 08:17 +0200, Krzysztof Kozlowski wrote:
>> On 20/07/2023 00:08, Iwona Winiarska wrote:
>>> Hi!
>>>
>>> The series adds support for PECI on Nuvoton-based BMC boards.
>>> It is based on patches that were sent by Tomer Maimon from
>>> Nuvoton [1].
>>> Similar to Aspeed driver, unused (as in, default values were used in
>>> all of the available DTS files) vendor-specific properties were
>>> removed.
>>> If there is a use-case for such properties, they can be added in
>>> a separate series.
>>>
>>> Thank you Tomer for testing this series on Nuvoton hardware.
>>>
>>> Thanks
>>> -Iwona
>>>
>>> [1]
>>> https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/
>>>
>>
>> This is not v1 but v3 or v4. Please provide proper changelog and versioning.
>
> This is the first submission - also known as v1 :)
> Could you elaborate on why do you believe that this is v3 or v4?
I had such impression because I saw it:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof
On Thu, 2023-07-20 at 10:40 +0200, Krzysztof Kozlowski wrote:
> On 20/07/2023 10:00, Winiarska, Iwona wrote:
> > On Thu, 2023-07-20 at 08:17 +0200, Krzysztof Kozlowski wrote:
> > > On 20/07/2023 00:08, Iwona Winiarska wrote:
> > > > Hi!
> > > >
> > > > The series adds support for PECI on Nuvoton-based BMC boards.
> > > > It is based on patches that were sent by Tomer Maimon from
> > > > Nuvoton [1].
> > > > Similar to Aspeed driver, unused (as in, default values were used in
> > > > all of the available DTS files) vendor-specific properties were
> > > > removed.
> > > > If there is a use-case for such properties, they can be added in
> > > > a separate series.
> > > >
> > > > Thank you Tomer for testing this series on Nuvoton hardware.
> > > >
> > > > Thanks
> > > > -Iwona
> > > >
> > > > [1]
> > > > https://lore.kernel.org/openbmc/CAP6Zq1jnbQ8k9VEyf9WgVq5DRrEzf5V6kaYP30S7g9BV9jKtaQ@mail.gmail.com/
> > > >
> > >
> > > This is not v1 but v3 or v4. Please provide proper changelog and
> > > versioning.
> >
> > This is the first submission - also known as v1 :)
> > Could you elaborate on why do you believe that this is v3 or v4?
>
> I had such impression because I saw it:
> https://lore.kernel.org/all/[email protected]/
> https://lore.kernel.org/all/[email protected]/
Changelog / versioning is maintained for changes that are submitted for
inclusion in upstream Linux.
The series you're referring to are not upstream Linux submissions.
Additionally - there were no changes :)
-Iwona
>
> Best regards,
> Krzysztof
>