2023-07-20 10:49:08

by Tomi Valkeinen

Subject: [PATCH v2 5/8] media: i2c: ds90ub960: Allow FPD-Link async mode

Allow using FPD-Link in async mode. The driver handles it correctly, but
the mode was blocked at probe time as there wasn't HW to test this with.
Now the mode has been tested, and it works.

Signed-off-by: Tomi Valkeinen <[email protected]>
Reviewed-by: Andy Shevchenko <[email protected]>
---
drivers/media/i2c/ds90ub960.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
index a83091f47140..ea819fb6e99b 100644
--- a/drivers/media/i2c/ds90ub960.c
+++ b/drivers/media/i2c/ds90ub960.c
@@ -3240,7 +3240,6 @@ ub960_parse_dt_rxport_link_properties(struct ub960_data *priv,
switch (rx_mode) {
case RXPORT_MODE_RAW12_HF:
case RXPORT_MODE_RAW12_LF:
- case RXPORT_MODE_CSI2_ASYNC:
dev_err(dev, "rx%u: unsupported 'ti,rx-mode' %u\n", nport,
rx_mode);
return -EINVAL;

--
2.34.1

2023-07-25 18:11:37

by Laurent Pinchart

Subject: Re: [PATCH v2 5/8] media: i2c: ds90ub960: Allow FPD-Link async mode

Hi Tomi,

Thank you for the patch.

On Thu, Jul 20, 2023 at 01:30:36PM +0300, Tomi Valkeinen wrote:
> Allow using FPD-Link in async mode. The driver handles it correctly, but
> the mode was blocked at probe time as there wasn't HW to test this with.
> Now the mode has been tested, and it works.
>
> Signed-off-by: Tomi Valkeinen <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/ds90ub960.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c
> index a83091f47140..ea819fb6e99b 100644
> --- a/drivers/media/i2c/ds90ub960.c
> +++ b/drivers/media/i2c/ds90ub960.c
> @@ -3240,7 +3240,6 @@ ub960_parse_dt_rxport_link_properties(struct ub960_data *priv,
> switch (rx_mode) {
> case RXPORT_MODE_RAW12_HF:
> case RXPORT_MODE_RAW12_LF:
> - case RXPORT_MODE_CSI2_ASYNC:
> dev_err(dev, "rx%u: unsupported 'ti,rx-mode' %u\n", nport,
> rx_mode);
> return -EINVAL;
>

--
Regards,

Laurent Pinchart