2023-07-20 13:03:46

by M K, Muralidhara

Subject: [PATCH 4/7] EDAC/mc: Add new HBM3 memory type

From: Muralidhara M K <[email protected]>

Add a new entry to 'enum mem_type' and a new string to 'edac_mem_types[]'
for HBM3 (High Bandwidth Memory Gen 3) new memory type.

Signed-off-by: Muralidhara M K <[email protected]>
---
drivers/edac/edac_mc.c | 1 +
include/linux/edac.h | 3 +++
2 files changed, 4 insertions(+)

diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
index 6faeb2ab3960..d6eed727b0cd 100644
--- a/drivers/edac/edac_mc.c
+++ b/drivers/edac/edac_mc.c
@@ -166,6 +166,7 @@ const char * const edac_mem_types[] = {
[MEM_NVDIMM] = "Non-volatile-RAM",
[MEM_WIO2] = "Wide-IO-2",
[MEM_HBM2] = "High-bandwidth-memory-Gen2",
+ [MEM_HBM3] = "High-bandwidth-memory-Gen3",
};
EXPORT_SYMBOL_GPL(edac_mem_types);

diff --git a/include/linux/edac.h b/include/linux/edac.h
index fa4bda2a70f6..1174beb94ab6 100644
--- a/include/linux/edac.h
+++ b/include/linux/edac.h
@@ -187,6 +187,7 @@ static inline char *mc_event_error_type(const unsigned int err_type)
* @MEM_NVDIMM: Non-volatile RAM
* @MEM_WIO2: Wide I/O 2.
* @MEM_HBM2: High bandwidth Memory Gen 2.
+ * @MEM_HBM3: High bandwidth Memory Gen 3.
*/
enum mem_type {
MEM_EMPTY = 0,
@@ -218,6 +219,7 @@ enum mem_type {
MEM_NVDIMM,
MEM_WIO2,
MEM_HBM2,
+ MEM_HBM3,
};

#define MEM_FLAG_EMPTY BIT(MEM_EMPTY)
@@ -248,6 +250,7 @@ enum mem_type {
#define MEM_FLAG_NVDIMM BIT(MEM_NVDIMM)
#define MEM_FLAG_WIO2 BIT(MEM_WIO2)
#define MEM_FLAG_HBM2 BIT(MEM_HBM2)
+#define MEM_FLAG_HBM3 BIT(MEM_HBM3)

/**
* enum edac_type - Error Detection and Correction capabilities and mode
--
2.25.1

2023-08-03 14:42:00

by Borislav Petkov

Subject: Re: [PATCH 4/7] EDAC/mc: Add new HBM3 memory type

On Thu, Jul 20, 2023 at 12:54:22PM +0000, Muralidhara M K wrote:
> From: Muralidhara M K <[email protected]>
>
> Add a new entry to 'enum mem_type' and a new string to 'edac_mem_types[]'

Do not talk about *what* the patch is doing in the commit message - that
should be obvious from the diff itself. Rather, concentrate on the *why*
it needs to be done.

> for HBM3 (High Bandwidth Memory Gen 3) new memory type.
>
> Signed-off-by: Muralidhara M K <[email protected]>
> ---
> drivers/edac/edac_mc.c | 1 +
> include/linux/edac.h | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index 6faeb2ab3960..d6eed727b0cd 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -166,6 +166,7 @@ const char * const edac_mem_types[] = {
> [MEM_NVDIMM] = "Non-volatile-RAM",
> [MEM_WIO2] = "Wide-IO-2",
> [MEM_HBM2] = "High-bandwidth-memory-Gen2",
> + [MEM_HBM3] = "High-bandwidth-memory-Gen3",
> };
> EXPORT_SYMBOL_GPL(edac_mem_types);
>
> diff --git a/include/linux/edac.h b/include/linux/edac.h
> index fa4bda2a70f6..1174beb94ab6 100644
> --- a/include/linux/edac.h
> +++ b/include/linux/edac.h
> @@ -187,6 +187,7 @@ static inline char *mc_event_error_type(const unsigned int err_type)
> * @MEM_NVDIMM: Non-volatile RAM
> * @MEM_WIO2: Wide I/O 2.
> * @MEM_HBM2: High bandwidth Memory Gen 2.
> + * @MEM_HBM3: High bandwidth Memory Gen 3.

s/bandwidth/Bandwidth/g

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette