2023-07-20 14:54:04

by Yue Haibing

[permalink] [raw]
Subject: [PATCH -next] fs/9p: Remove unused extern declaration

commit bd238fb431f3 ("9p: Reorganization of 9p file system code")
left behind this.

Signed-off-by: YueHaibing <[email protected]>
---
fs/9p/v9fs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
index c7f774fe398f..d525957594b6 100644
--- a/fs/9p/v9fs.c
+++ b/fs/9p/v9fs.c
@@ -545,8 +545,6 @@ void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses)
p9_client_begin_disconnect(v9ses->clnt);
}

-extern int v9fs_error_init(void);
-
static struct kobject *v9fs_kobj;

#ifdef CONFIG_9P_FSCACHE
--
2.34.1



2023-07-20 19:02:09

by Christian Schoenebeck

[permalink] [raw]
Subject: Re: [PATCH -next] fs/9p: Remove unused extern declaration

On Thursday, July 20, 2023 4:35:06 PM CEST YueHaibing wrote:
> commit bd238fb431f3 ("9p: Reorganization of 9p file system code")
> left behind this.

Right, it renamed v9fs_error_init() -> p9_error_init().

What a giant patch that was BTW (3422+, 3130-).

> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Christian Schoenebeck <[email protected]>

> ---
> fs/9p/v9fs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
> index c7f774fe398f..d525957594b6 100644
> --- a/fs/9p/v9fs.c
> +++ b/fs/9p/v9fs.c
> @@ -545,8 +545,6 @@ void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses)
> p9_client_begin_disconnect(v9ses->clnt);
> }
>
> -extern int v9fs_error_init(void);
> -
> static struct kobject *v9fs_kobj;
>
> #ifdef CONFIG_9P_FSCACHE
>



2023-07-20 21:49:33

by Eric Van Hensbergen

[permalink] [raw]
Subject: Re: [PATCH -next] fs/9p: Remove unused extern declaration


On Thu, 20 Jul 2023 22:35:06 +0800, YueHaibing wrote:
> commit bd238fb431f3 ("9p: Reorganization of 9p file system code")
> left behind this.
>
>

Applied, thanks!

[1/1] fs/9p: Remove unused extern declaration
commit: e6ab0b914c12acefbb0880dded48cb930ccab5cf

Best regards,
--
Eric Van Hensbergen <[email protected]>