2023-07-20 23:33:49

by Min-Hua Chen

Subject: [PATCH v2] iommu/apple-dart: mark apple_dart_pm_ops static

This patch fixes the following sparse warning:

drivers/iommu/apple-dart.c:1279:1: sparse: warning: symbol 'apple_dart_pm_ops' was not declared. Should it be static?

No functional change intended.

Signed-off-by: Min-Hua Chen <[email protected]>
Acked-by: Sven Peter <[email protected]>

---

Change since v1:
fix a typo

---
drivers/iommu/apple-dart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c
index 8af64b57f048..2082081402d3 100644
--- a/drivers/iommu/apple-dart.c
+++ b/drivers/iommu/apple-dart.c
@@ -1276,7 +1276,7 @@ static __maybe_unused int apple_dart_resume(struct device *dev)
return 0;
}

-DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(apple_dart_pm_ops, apple_dart_suspend, apple_dart_resume);

static const struct of_device_id apple_dart_of_match[] = {
{ .compatible = "apple,t8103-dart", .data = &apple_dart_hw_t8103 },
--
2.34.1

2023-08-07 13:18:40

by Joerg Roedel

Subject: Re: [PATCH v2] iommu/apple-dart: mark apple_dart_pm_ops static

On Fri, Jul 21, 2023 at 07:21:54AM +0800, Min-Hua Chen wrote:
> Signed-off-by: Min-Hua Chen <[email protected]>
> Acked-by: Sven Peter <[email protected]>

Applied, thanks.