2023-07-21 10:15:35

by Andrei Coardos

Subject: [PATCH] gpio: lp873x: remove unnecessary call to platform_set_drvdata()

This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <[email protected]>
Signed-off-by: Andrei Coardos <[email protected]>
---
drivers/gpio/gpio-lp873x.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpio-lp873x.c b/drivers/gpio/gpio-lp873x.c
index 5c79ba1f229c..7427a74ce4e2 100644
--- a/drivers/gpio/gpio-lp873x.c
+++ b/drivers/gpio/gpio-lp873x.c
@@ -140,8 +140,6 @@ static int lp873x_gpio_probe(struct platform_device *pdev)
if (!gpio)
return -ENOMEM;

- platform_set_drvdata(pdev, gpio);
-
gpio->lp873 = dev_get_drvdata(pdev->dev.parent);
gpio->chip = template_chip;
gpio->chip.parent = gpio->lp873->dev;
--
2.34.1

2023-07-21 11:11:05

by Andy Shevchenko

Subject: Re: [PATCH] gpio: lp873x: remove unnecessary call to platform_set_drvdata()

On Fri, Jul 21, 2023 at 12:43:43PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.

Wrong version of the patch. Use -v<X>, where <X> is a number.

> Reviewed-by: Alexandru Ardelean <[email protected]>
> Signed-off-by: Andrei Coardos <[email protected]>
> ---

There is no changelog. What has been changed? What's the difference to v1
if this is assumed v2?

--
With Best Regards,
Andy Shevchenko