2023-07-19 13:57:58

by Zhangjin Wu

[permalink] [raw]
Subject: [PATCH v2 06/14] selftests/nolibc: add mrproper for development

When want to start a new building with O= option, the old generated
files in the source code tree must be mrproper-ed, adding mrproper
target here to avoid switch to the source code tree manually.

Signed-off-by: Zhangjin Wu <[email protected]>
---
tools/testing/selftests/nolibc/Makefile | 3 +++
1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
index 06954b4b3885..9d9902b54e5e 100644
--- a/tools/testing/selftests/nolibc/Makefile
+++ b/tools/testing/selftests/nolibc/Makefile
@@ -199,6 +199,9 @@ MAKE_KERNEL = $(MAKE) -C $(srctree) ARCH=$(ARCH) CC=$(CC) CROSS_COMPILE=$(CROS
KERNEL_CONFIG = $(objtree)/.config
KERNEL_IMAGE = $(objtree)/$(IMAGE)

+mrproper:
+ $(Q)$(MAKE_KERNEL) mrproper
+
defconfig:
$(Q)$(MAKE_KERNEL) mrproper $(DEFCONFIG) prepare

--
2.25.1



2023-07-22 13:59:50

by Willy Tarreau

[permalink] [raw]
Subject: Re: [PATCH v2 06/14] selftests/nolibc: add mrproper for development

On Wed, Jul 19, 2023 at 09:23:48PM +0800, Zhangjin Wu wrote:
> +mrproper:
> + $(Q)$(MAKE_KERNEL) mrproper
> +

Same as previous one, I'm not convinced about the benefit at all.
As a user I would expect that it cleans everything in the build
directory while in fact it seems it will only apply to the kernel.

Willy