2023-07-21 11:11:13

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] iio: adc: meson: improve error logging at probe stage

On Fri, Jul 21, 2023 at 01:23:09PM +0300, George Stark wrote:
> Add log messages for errors that may occur at probe stage

the probe

stage.

--
With Best Regards,
Andy Shevchenko




2023-07-22 17:34:29

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] iio: adc: meson: improve error logging at probe stage

On Fri, 21 Jul 2023 13:43:51 +0300
Andy Shevchenko <[email protected]> wrote:

> On Fri, Jul 21, 2023 at 01:23:09PM +0300, George Stark wrote:
> > Add log messages for errors that may occur at probe stage
>
> the probe

British English - excellent ! :) (I argue this one far too often in
specification committees :)


>
> stage.
>

I can tidy this up, but the patch will be a while anyway given the fix
needs to work it's way into the upstream for my togreg branch (and I need
to have send a pull request for togreg as well).

Jonathan


2023-10-03 12:47:22

by George Stark

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] iio: adc: meson: improve error logging at probe stage

Hello Jonathan

It seems like you haven't had time for this patch yet. Should I fix it
myself or just be more patient?

On 7/22/23 20:15, Jonathan Cameron wrote:
> On Fri, 21 Jul 2023 13:43:51 +0300
> Andy Shevchenko <[email protected]> wrote:
>
>> On Fri, Jul 21, 2023 at 01:23:09PM +0300, George Stark wrote:
>>> Add log messages for errors that may occur at probe stage
>>
>> the probe
>
> British English - excellent ! :) (I argue this one far too often in
> specification committees :)
>
>
>>
>> stage.
>>
>
> I can tidy this up, but the patch will be a while anyway given the fix
> needs to work it's way into the upstream for my togreg branch (and I need
> to have send a pull request for togreg as well).
>
> Jonathan
>

--
Best regards
George

2023-10-05 15:58:43

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] iio: adc: meson: improve error logging at probe stage

On Tue, 3 Oct 2023 15:47:23 +0300
George Stark <[email protected]> wrote:

> Hello Jonathan
>
> It seems like you haven't had time for this patch yet. Should I fix it
> myself or just be more patient?
I've been exceptionally slow on this one. Was still sitting in patchwork
but I'd failed to notice the dependency was now upstream.

Applied to the togreg branch of iio.git and I'll push that out initially
as testing later today (I have to do a rebase to fix up an issue
0-day caught on previous push before I do).

Thanks for the poke and sorry it was necessary!

Jonathan

>
> On 7/22/23 20:15, Jonathan Cameron wrote:
> > On Fri, 21 Jul 2023 13:43:51 +0300
> > Andy Shevchenko <[email protected]> wrote:
> >
> >> On Fri, Jul 21, 2023 at 01:23:09PM +0300, George Stark wrote:
> >>> Add log messages for errors that may occur at probe stage
> >>
> >> the probe
> >
> > British English - excellent ! :) (I argue this one far too often in
> > specification committees :)
> >
> >
> >>
> >> stage.
> >>
> >
> > I can tidy this up, but the patch will be a while anyway given the fix
> > needs to work it's way into the upstream for my togreg branch (and I need
> > to have send a pull request for togreg as well).
> >
> > Jonathan
> >
>