2023-07-24 12:29:13

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency

From: Arnd Bergmann <[email protected]>

The driver now uses the backlight interface, which breaks when that
is disabled:

ld.lld: error: undefined symbol: devm_backlight_device_register

Enforce the necessary Kconfig dependency to avoid this.

Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index e8c9f4613a4b4..b097b2507ac5b 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -300,6 +300,7 @@ config DRM_PANEL_LEADTEK_LTK500HD1829
config DRM_PANEL_SAMSUNG_LD9040
tristate "Samsung LD9040 RGB/SPI panel"
depends on OF && SPI
+ depends on BACKLIGHT_CLASS_DEVICE
select VIDEOMODE_HELPERS

config DRM_PANEL_LG_LB035Q02
--
2.39.2



2023-07-24 17:25:14

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency

On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The driver now uses the backlight interface, which breaks when that
> is disabled:
>
> ld.lld: error: undefined symbol: devm_backlight_device_register
>
> Enforce the necessary Kconfig dependency to avoid this.
>
> Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight device")
> Signed-off-by: Arnd Bergmann <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>

I expect that someone else with drm-misc rights apply the patch.

Sam

2023-07-24 23:34:09

by Paul Cercueil

[permalink] [raw]
Subject: Re: [PATCH] drm/panel: ld9040: add backlight Kconfig dependency

Hi,

Le lundi 24 juillet 2023 à 19:11 +0200, Sam Ravnborg a écrit :
> On Mon, Jul 24, 2023 at 02:17:05PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <[email protected]>
> >
> > The driver now uses the backlight interface, which breaks when that
> > is disabled:
> >
> > ld.lld: error: undefined symbol: devm_backlight_device_register
> >
> > Enforce the necessary Kconfig dependency to avoid this.
> >
> > Fixes: c2268daa65fb4 ("drm/panel: ld9040: Register a backlight
> > device")
> > Signed-off-by: Arnd Bergmann <[email protected]>
> Reviewed-by: Sam Ravnborg <[email protected]>
>
> I expect that someone else with drm-misc rights apply the patch.

Pushed to drm-misc-next.

Thanks,
-Paul