Add small changes to address the review comments from Paval which were
posted after the driver was applied:
https://lore.kernel.org/linux-arm-msm/20230325170957.GA2904@bug/#t
https://lore.kernel.org/linux-arm-msm/[email protected]/
1) Add a sentence in Kconfig to explain the driver can be compiled as a
module
2) Strobe off the LED channel before setting flash current
3) Put the child node while register flash LED device failed.
Changes in v2:
Sperate the fixes into 3 independent changes.
Signed-off-by: Fenglin Wu <[email protected]>
---
Fenglin Wu (3):
leds: flash: leds-qcom-flash: declare the driver as a module
leds: flash: leds-qcom-flash: turn off LED before setting flash current
leds: flash: leds-qcom-flash: put child node if registration failed
drivers/leds/flash/Kconfig | 2 ++
drivers/leds/flash/leds-qcom-flash.c | 5 +++++
2 files changed, 7 insertions(+)
---
base-commit: 7a2b85a76b05f16e8e788d035afcacdd4faa1d71
change-id: 20230725-leds-qcom-flash-driver-tiny-fixes-f6fd8d90eb94
Best regards,
--
Fenglin Wu <[email protected]>
Explain in Kconfig that the driver can be compiled as a module.
Signed-off-by: Fenglin Wu <[email protected]>
---
drivers/leds/flash/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
index 4ed2efc65434..4e08dbc05709 100644
--- a/drivers/leds/flash/Kconfig
+++ b/drivers/leds/flash/Kconfig
@@ -89,6 +89,8 @@ config LEDS_QCOM_FLASH
the total LED current will be split symmetrically on each channel and
they will be enabled/disabled at the same time.
+ This driver can be built as a module, it will be called "leds-qcom-flash".
+
config LEDS_RT4505
tristate "LED support for RT4505 flashlight controller"
depends on I2C && OF
--
2.25.1
On Tue, 25 Jul 2023 17:57:18 +0800, Fenglin Wu wrote:
> Add small changes to address the review comments from Paval which were
> posted after the driver was applied:
> https://lore.kernel.org/linux-arm-msm/20230325170957.GA2904@bug/#t
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> 1) Add a sentence in Kconfig to explain the driver can be compiled as a
> module
> 2) Strobe off the LED channel before setting flash current
> 3) Put the child node while register flash LED device failed.
>
> [...]
Applied, thanks!
[1/3] leds: flash: leds-qcom-flash: declare the driver as a module
commit: 05a576059ac23355a86e4be058cb43997d83c7fd
[2/3] leds: flash: leds-qcom-flash: turn off LED before setting flash current
commit: 7c47381c8664d55861036d1d858daf5e9d5d67b8
[3/3] leds: flash: leds-qcom-flash: put child node if registration failed
commit: 546924102de8327a5b2095d2134faed6de971476
--
Lee Jones [李琼斯]