2023-07-25 09:23:44

by Konrad Dybcio

Subject: [PATCH] clk: qcom: dispcc-sc8280xp: Use ret registers on GDSCs

The DISP_CC GDSCs have not been instructed to use the ret registers.
Fix that.

Fixes: 4a66e76fdb6d ("clk: qcom: Add SC8280XP display clock controller")
Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/clk/qcom/dispcc-sc8280xp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/qcom/dispcc-sc8280xp.c b/drivers/clk/qcom/dispcc-sc8280xp.c
index 167470beb369..30f636b9f0ec 100644
--- a/drivers/clk/qcom/dispcc-sc8280xp.c
+++ b/drivers/clk/qcom/dispcc-sc8280xp.c
@@ -3057,7 +3057,7 @@ static struct gdsc disp0_mdss_gdsc = {
.name = "disp0_mdss_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
- .flags = HW_CTRL,
+ .flags = HW_CTRL | RETAIN_FF_ENABLE,
};

static struct gdsc disp1_mdss_gdsc = {
@@ -3069,7 +3069,7 @@ static struct gdsc disp1_mdss_gdsc = {
.name = "disp1_mdss_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
- .flags = HW_CTRL,
+ .flags = HW_CTRL | RETAIN_FF_ENABLE,
};

static struct gdsc disp0_mdss_int2_gdsc = {
@@ -3081,7 +3081,7 @@ static struct gdsc disp0_mdss_int2_gdsc = {
.name = "disp0_mdss_int2_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
- .flags = HW_CTRL,
+ .flags = HW_CTRL | RETAIN_FF_ENABLE,
};

static struct gdsc disp1_mdss_int2_gdsc = {
@@ -3093,7 +3093,7 @@ static struct gdsc disp1_mdss_int2_gdsc = {
.name = "disp1_mdss_int2_gdsc",
},
.pwrsts = PWRSTS_OFF_ON,
- .flags = HW_CTRL,
+ .flags = HW_CTRL | RETAIN_FF_ENABLE,
};

static struct gdsc *disp0_cc_sc8280xp_gdscs[] = {

---
base-commit: 1e25dd7772483f477f79986d956028e9f47f990a
change-id: 20230725-topic-8280_dispcc_gdsc-b1a7f3e51f3c

Best regards,
--
Konrad Dybcio <[email protected]>

2023-07-28 04:47:13

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: dispcc-sc8280xp: Use ret registers on GDSCs

On Tue, 25 Jul 2023 10:51:56 +0200, Konrad Dybcio wrote:
> The DISP_CC GDSCs have not been instructed to use the ret registers.
> Fix that.
>
>

Applied, thanks!

[1/1] clk: qcom: dispcc-sc8280xp: Use ret registers on GDSCs
commit: 20e1d75bc043c5ec1fd8f5169fde17db89eb11c3

Best regards,
--
Bjorn Andersson <[email protected]>