2023-07-25 13:49:42

by Naresh Solanki

Subject: [PATCH v2 1/3] pmbus_core: Refactor pmbus_is_enabled function

From: Patrick Rudolph <[email protected]>

Refactor the pmbus_is_enabled() function to return the raw status
without any additional processing as its already done in
_pmbus_is_enabled function.

Signed-off-by: Patrick Rudolph <[email protected]>
Signed-off-by: Naresh Solanki <[email protected]>
---
drivers/hwmon/pmbus/pmbus_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index fa06325f5a7c..42fb7286805b 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -2768,7 +2768,7 @@ static int __maybe_unused pmbus_is_enabled(struct device *dev, u8 page)
ret = _pmbus_is_enabled(dev, page);
mutex_unlock(&data->update_lock);

- return !!(ret & PB_OPERATION_CONTROL_ON);
+ return ret;
}

#define to_dev_attr(_dev_attr) \

base-commit: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7
--
2.41.0

2023-07-25 15:04:59

by Guenter Roeck

Subject: Re: [PATCH v2 1/3] pmbus_core: Refactor pmbus_is_enabled function

On Tue, Jul 25, 2023 at 02:54:25PM +0200, Naresh Solanki wrote:
> From: Patrick Rudolph <[email protected]>
>
> Refactor the pmbus_is_enabled() function to return the raw status
> without any additional processing as its already done in
> _pmbus_is_enabled function.
>
> Signed-off-by: Patrick Rudolph <[email protected]>
> Signed-off-by: Naresh Solanki <[email protected]>

Applied. I rephrased the commit message so don't be surprised that
it looks different.

Thanks,
Guenter

> ---
> drivers/hwmon/pmbus/pmbus_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: 55612007f16b5d7b1fb83a7b0f5bb686829db7c7
>
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index fa06325f5a7c..42fb7286805b 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -2768,7 +2768,7 @@ static int __maybe_unused pmbus_is_enabled(struct device *dev, u8 page)
> ret = _pmbus_is_enabled(dev, page);
> mutex_unlock(&data->update_lock);
>
> - return !!(ret & PB_OPERATION_CONTROL_ON);
> + return ret;
> }
>
> #define to_dev_attr(_dev_attr) \