2023-07-25 16:00:11

by Ghimiray, Himal Prasad

[permalink] [raw]
Subject: [PATCH v8 1/3] fault-inject: Include linux/types.h by default.

Functions should_fail_alloc_page, should_failslab, and __should_failslab
are declared irrespective of CONFIG_FAULT_INJECTION. These functions use
bool and gfp_t types, which are treated as unknown when CONFIG_FAULT_INJECTION
is disabled because the inclusion of linux/types.h is missing.

Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure")

v2:
- Add fixes tag (Badal)
- Rectify Cc. (Lucas)

Cc: Lucas De Marchi <[email protected]>
Cc: Rodrigo Vivi <[email protected]>
Cc: Badal Nilawar <[email protected]>
Cc: Akinobu Mita <[email protected]>
Cc: Jason Gunthorpe <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Qi Zheng <[email protected]>
Cc: [email protected]
Signed-off-by: Himal Prasad Ghimiray <[email protected]>
---
include/linux/fault-inject.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
index 481abf530b3c..f83ab2b6cd08 100644
--- a/include/linux/fault-inject.h
+++ b/include/linux/fault-inject.h
@@ -2,9 +2,10 @@
#ifndef _LINUX_FAULT_INJECT_H
#define _LINUX_FAULT_INJECT_H

+#include <linux/types.h>
+
#ifdef CONFIG_FAULT_INJECTION

-#include <linux/types.h>
#include <linux/debugfs.h>
#include <linux/configfs.h>
#include <linux/ratelimit.h>
--
2.25.1