2023-07-26 07:49:59

by Raghu Halharvi

Subject: [PATCH v7 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc

Issue found with checkpatch

A return of errno should be good enough if the memory allocation fails,
the error message here is redundant as per the coding style, removing
it.

Signed-off-by: Raghu Halharvi <[email protected]>
Reviewed-by: Vishal Verma <[email protected]>
Reviewed-by: Dave Jiang <[email protected]>
Reviewed-by: Ira Weiny <[email protected]>
---
drivers/cxl/core/mbox.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index d6d067fbee97..af7f37cea871 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1325,10 +1325,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev)
struct cxl_memdev_state *mds;

mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL);
- if (!mds) {
- dev_err(dev, "No memory available\n");
+ if (!mds)
return ERR_PTR(-ENOMEM);
- }

mutex_init(&mds->mbox_mutex);
mutex_init(&mds->event.log_lock);
--
2.39.2

2023-07-30 03:06:50

by Alison Schofield

Subject: Re: [PATCH v7 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc

On Wed, Jul 26, 2023 at 07:34:20AM +0000, Raghu Halharvi wrote:
> Issue found with checkpatch
>
> A return of errno should be good enough if the memory allocation fails,
> the error message here is redundant as per the coding style, removing
> it.
>
> Signed-off-by: Raghu Halharvi <[email protected]>
> Reviewed-by: Vishal Verma <[email protected]>
> Reviewed-by: Dave Jiang <[email protected]>
> Reviewed-by: Ira Weiny <[email protected]>

Thanks for follow-up Raghu!

Reviewed-by: Alison Schofield <[email protected]>


> ---
> drivers/cxl/core/mbox.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index d6d067fbee97..af7f37cea871 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -1325,10 +1325,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev)
> struct cxl_memdev_state *mds;
>
> mds = devm_kzalloc(dev, sizeof(*mds), GFP_KERNEL);
> - if (!mds) {
> - dev_err(dev, "No memory available\n");
> + if (!mds)
> return ERR_PTR(-ENOMEM);
> - }
>
> mutex_init(&mds->mbox_mutex);
> mutex_init(&mds->event.log_lock);
> --
> 2.39.2
>