by Takahiro Kuwano

[permalink] [raw]

Subject: Re: [PATCH v4 10/11] mtd: spi-nor: spansion: switch s25hx_t to use vreg_offset for quad_enable()

On 7/26/2023 4:52 PM, Tudor Ambarus wrote:
> All s25hx_t flashes have single or multi chip flavors and already use
> n_dice and vreg_offset in cypress_nor_sr_ready_and_clear. Switch s25hx_t
> to always use vreg_offset for the quad_enable() method, so that we use
> the same code base for both single and multi chip package flashes.
>
> Signed-off-by: Tudor Ambarus <[email protected]>
> ---
> drivers/mtd/spi-nor/spansion.c | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 30a3ffbfa381..6abef5b515a1 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -24,8 +24,6 @@
> #define SPINOR_REG_CYPRESS_STR1V \
> (SPINOR_REG_CYPRESS_VREG + SPINOR_REG_CYPRESS_STR1)
> #define SPINOR_REG_CYPRESS_CFR1 0x2
> -#define SPINOR_REG_CYPRESS_CFR1V \
> - (SPINOR_REG_CYPRESS_VREG + SPINOR_REG_CYPRESS_CFR1)
> #define SPINOR_REG_CYPRESS_CFR1_QUAD_EN BIT(1) /* Quad Enable */
> #define SPINOR_REG_CYPRESS_CFR2 0x3
> #define SPINOR_REG_CYPRESS_CFR2V \
> @@ -348,10 +346,6 @@ static int cypress_nor_quad_enable_volatile(struct spi_nor *nor)
> u8 i;
> int ret;
>
> - if (!params->n_dice)
> - return cypress_nor_quad_enable_volatile_reg(nor,
> - SPINOR_REG_CYPRESS_CFR1V);
> -
> for (i = 0; i < params->n_dice; i++) {
> addr = params->vreg_offset[i] + SPINOR_REG_CYPRESS_CFR1;
> ret = cypress_nor_quad_enable_volatile_reg(nor, addr);
> @@ -657,15 +651,17 @@ static int s25hx_t_late_init(struct spi_nor *nor)
> {
> struct spi_nor_flash_parameter *params = nor->params;
>
> + if (!params->n_dice || !params->vreg_offset) {
> + dev_err(nor->dev, "%s failed. The volatile register offset could not be retrieved from SFDP.\n",
> + __func__);
> + return -EOPNOTSUPP;
> + }
> +
> /* Fast Read 4B requires mode cycles */
> params->reads[SNOR_CMD_READ_FAST].num_mode_clocks = 8;
> -
> + params->ready = cypress_nor_sr_ready_and_clear;
> cypress_nor_ecc_init(nor);
>
> - /* Replace ready() with multi die version */
> - if (params->n_dice)
> - params->ready = cypress_nor_sr_ready_and_clear;
> -
> return 0;
> }
>

Tested-by: Takahiro Kuwano <[email protected]>

2023-07-26 11:23:30

by Takahiro Kuwano

[permalink] [raw]

Subject: Re: [PATCH v4 09/11] mtd: spi-nor: spansion: let SFDP determine the flash and sector size

On 7/26/2023 4:52 PM, Tudor Ambarus wrote:
> sector_size is used to determine the flash size and the erase size in
> case of uniform erase. n_sectors is used to determine the flash_size.
> But the flash size and the erase sizes are determined when parsing SFDP,
> let SFDP determine them.
>
> Signed-off-by: Tudor Ambarus <[email protected]>
> ---
> drivers/mtd/spi-nor/spansion.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 1c5671a3751a..30a3ffbfa381 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -873,11 +873,11 @@ static const struct flash_info spansion_nor_parts[] = {
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25fs256t_fixups },
> - { "s25hl512t", INFO6(0x342a1a, 0x0f0390, 256 * 1024, 256)
> + { "s25hl512t", INFO6(0x342a1a, 0x0f0390, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> - { "s25hl01gt", INFO6(0x342a1b, 0x0f0390, 256 * 1024, 512)
> + { "s25hl01gt", INFO6(0x342a1b, 0x0f0390, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> @@ -886,11 +886,11 @@ static const struct flash_info spansion_nor_parts[] = {
> MFR_FLAGS(USE_CLPEF)
> FLAGS(NO_CHIP_ERASE)
> .fixups = &s25hx_t_fixups },
> - { "s25hs512t", INFO6(0x342b1a, 0x0f0390, 256 * 1024, 256)
> + { "s25hs512t", INFO6(0x342b1a, 0x0f0390, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> - { "s25hs01gt", INFO6(0x342b1b, 0x0f0390, 256 * 1024, 512)
> + { "s25hs01gt", INFO6(0x342b1b, 0x0f0390, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s25hx_t_fixups },
> @@ -901,22 +901,22 @@ static const struct flash_info spansion_nor_parts[] = {
> .fixups = &s25hx_t_fixups },
> { "cy15x104q", INFO6(0x042cc2, 0x7f7f7f, 512 * 1024, 1)
> FLAGS(SPI_NOR_NO_ERASE) },
> - { "s28hl512t", INFO(0x345a1a, 0, 256 * 1024, 256)
> + { "s28hl512t", INFO(0x345a1a, 0, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> - { "s28hl01gt", INFO(0x345a1b, 0, 256 * 1024, 512)
> + { "s28hl01gt", INFO(0x345a1b, 0, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> - { "s28hs512t", INFO(0x345b1a, 0, 256 * 1024, 256)
> + { "s28hs512t", INFO(0x345b1a, 0, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,
> },
> - { "s28hs01gt", INFO(0x345b1b, 0, 256 * 1024, 512)
> + { "s28hs01gt", INFO(0x345b1b, 0, 0, 0)
> PARSE_SFDP
> MFR_FLAGS(USE_CLPEF)
> .fixups = &s28hx_t_fixups,

Tested-by: Takahiro Kuwano <[email protected]>