2023-07-26 15:37:23

by Yue Haibing

[permalink] [raw]
Subject: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()

Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
this is not used, so can remove it.

Signed-off-by: YueHaibing <[email protected]>
---
net/bridge/br_private.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index 51e4ca54b537..a1f4acfa6994 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -974,7 +974,6 @@ int br_multicast_set_vlan_router(struct net_bridge_vlan *v, u8 mcast_router);
int br_multicast_toggle(struct net_bridge *br, unsigned long val,
struct netlink_ext_ack *extack);
int br_multicast_set_querier(struct net_bridge_mcast *brmctx, unsigned long val);
-int br_multicast_set_hash_max(struct net_bridge *br, unsigned long val);
int br_multicast_set_igmp_version(struct net_bridge_mcast *brmctx,
unsigned long val);
#if IS_ENABLED(CONFIG_IPV6)
--
2.34.1



2023-07-27 11:58:45

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()

On Wed, Jul 26, 2023 at 10:31:41PM +0800, YueHaibing wrote:
> Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> this is not used, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2023-07-27 12:04:47

by Nikolay Aleksandrov

[permalink] [raw]
Subject: Re: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()

On 7/26/23 17:31, YueHaibing wrote:
> Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> this is not used, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> net/bridge/br_private.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 51e4ca54b537..a1f4acfa6994 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -974,7 +974,6 @@ int br_multicast_set_vlan_router(struct net_bridge_vlan *v, u8 mcast_router);
> int br_multicast_toggle(struct net_bridge *br, unsigned long val,
> struct netlink_ext_ack *extack);
> int br_multicast_set_querier(struct net_bridge_mcast *brmctx, unsigned long val);
> -int br_multicast_set_hash_max(struct net_bridge *br, unsigned long val);
> int br_multicast_set_igmp_version(struct net_bridge_mcast *brmctx,
> unsigned long val);
> #if IS_ENABLED(CONFIG_IPV6)

Acked-by: Nikolay Aleksandrov <[email protected]>


2023-07-28 01:11:42

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] bridge: Remove unused declaration br_multicast_set_hash_max()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 26 Jul 2023 22:31:41 +0800 you wrote:
> Since commit 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable")
> this is not used, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> net/bridge/br_private.h | 1 -
> 1 file changed, 1 deletion(-)

Here is the summary with links:
- [net-next] bridge: Remove unused declaration br_multicast_set_hash_max()
https://git.kernel.org/netdev/net-next/c/4d66f235c790

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html