Subject: [PATCH v1 0/2] LTC4286 and LTC4287 driver support

v1 - Add LTC4286 and LTC4287 binding document
- Add LTC4286 and LTC4287 driver

Delphine CC Chiu (2):
dt-bindings: hwmon: Add lltc ltc4286 driver bindings
hwmon: pmbus: Add ltc4286 driver

.../bindings/hwmon/lltc,ltc4286.yaml | 47 ++++++
MAINTAINERS | 9 ++
drivers/hwmon/pmbus/Kconfig | 9 ++
drivers/hwmon/pmbus/Makefile | 1 +
drivers/hwmon/pmbus/ltc4286.c | 142 ++++++++++++++++++
5 files changed, 208 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
create mode 100644 drivers/hwmon/pmbus/ltc4286.c

--
2.17.1


Subject: [PATCH 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

Add a device tree bindings for ltc4286 driver.

Signed-off-by: Delphine CC Chiu <[email protected]>
---
.../bindings/hwmon/lltc,ltc4286.yaml | 49 +++++++++++++++++++
MAINTAINERS | 9 ++++
2 files changed, 58 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
new file mode 100644
index 000000000000..ad7f6ad888e4
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LTC4286 power monitors
+
+maintainers:
+ - Delphine CC Chiu <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - lltc,ltc4286
+ - lltc,ltc4287
+
+ reg:
+ maxItems: 1
+
+ vrange_select_25p6:
+ description:
+ This property is a bool parameter to represent the
+ voltage range is 25.6 or not for this chip.
+
+ shunt-resistor-micro-ohms:
+ description:
+ Resistor value in micro-Ohm
+
+required:
+ - compatible
+ - reg
+ - shunt-resistor-micro-ohms
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ power-sensor@40 {
+ compatible = "lltc,ltc4286";
+ reg = <0x40>;
+ vrange_select_25p6;
+ shunt-resistor-micro-ohms = <300>;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index d516295978a4..7c1cb9bd4f45 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12344,6 +12344,15 @@ S: Maintained
F: Documentation/hwmon/ltc4261.rst
F: drivers/hwmon/ltc4261.c

+LTC4286 HARDWARE MONITOR DRIVER
+M: Delphine CC Chiu <[email protected]>
+L: [email protected]
+S: Maintained
+F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
+F: drivers/hwmon/pmbus/Kconfig
+F: drivers/hwmon/pmbus/Makefile
+F: drivers/hwmon/pmbus/ltc4286.c
+
LTC4306 I2C MULTIPLEXER DRIVER
M: Michael Hennerich <[email protected]>
L: [email protected]
--
2.25.1


2023-07-26 17:08:29

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

On Mon, Jul 24, 2023 at 06:05:11PM +0800, Delphine CC Chiu wrote:
> Add a device tree bindings for ltc4286 driver.
>
> Signed-off-by: Delphine CC Chiu <[email protected]>
> ---
> .../bindings/hwmon/lltc,ltc4286.yaml | 49 +++++++++++++++++++
> MAINTAINERS | 9 ++++
> 2 files changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> new file mode 100644
> index 000000000000..ad7f6ad888e4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4286.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTC4286 power monitors
> +
> +maintainers:
> + - Delphine CC Chiu <[email protected]>
> +
> +properties:
> + compatible:
> + enum:
> + - lltc,ltc4286
> + - lltc,ltc4287
> +
> + reg:
> + maxItems: 1
> +
> + vrange_select_25p6:

Needs a vendor prefix and don't use '_'.

> + description:
> + This property is a bool parameter to represent the

We have types, don't define the type in free form text.

> + voltage range is 25.6 or not for this chip.
> +
> + shunt-resistor-micro-ohms:
> + description:
> + Resistor value in micro-Ohm
> +
> +required:
> + - compatible
> + - reg
> + - shunt-resistor-micro-ohms
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + power-sensor@40 {
> + compatible = "lltc,ltc4286";
> + reg = <0x40>;
> + vrange_select_25p6;
> + shunt-resistor-micro-ohms = <300>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d516295978a4..7c1cb9bd4f45 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12344,6 +12344,15 @@ S: Maintained
> F: Documentation/hwmon/ltc4261.rst
> F: drivers/hwmon/ltc4261.c
>
> +LTC4286 HARDWARE MONITOR DRIVER
> +M: Delphine CC Chiu <[email protected]>
> +L: [email protected]
> +S: Maintained
> +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> +F: drivers/hwmon/pmbus/Kconfig
> +F: drivers/hwmon/pmbus/Makefile
> +F: drivers/hwmon/pmbus/ltc4286.c
> +
> LTC4306 I2C MULTIPLEXER DRIVER
> M: Michael Hennerich <[email protected]>
> L: [email protected]
> --
> 2.25.1
>

Subject: RE: [PATCH 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

> -----Original Message-----
> From: Rob Herring <[email protected]>
> Sent: Thursday, July 27, 2023 12:44 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>
> Cc: [email protected]; Jean Delvare <[email protected]>; Guenter Roeck
> <[email protected]>; Krzysztof Kozlowski <[email protected]>;
> Conor Dooley <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
>
> Security Reminder: Please be aware that this email is sent by an external
> sender.
>
> On Mon, Jul 24, 2023 at 06:05:11PM +0800, Delphine CC Chiu wrote:
> > Add a device tree bindings for ltc4286 driver.
> >
> > Signed-off-by: Delphine CC Chiu <[email protected]>
> > ---
> > .../bindings/hwmon/lltc,ltc4286.yaml | 49
> +++++++++++++++++++
> > MAINTAINERS | 9 ++++
> > 2 files changed, 58 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > new file mode 100644
> > index 000000000000..ad7f6ad888e4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fschemas%2Fhwmon%2Flltc%2Cltc4286.yaml%23&data=05%7C
> 01%7C
> >
> +Wayne_SC_Liu%40wiwynn.com%7Cd2e29aed8bdc47a743e508db8df786ac%7
> Cda6e06
> >
> +28fc834caf9dd273061cbab167%7C0%7C0%7C638259866495880680%7CUnkn
> own%7CT
> >
> +WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJ
> XVC
> >
> +I6Mn0%3D%7C3000%7C%7C%7C&sdata=n%2FyZyYnSEoCOcUgQFI6BERAgkKa
> zYA%2FmAt
> > +2NAlr1Xdo%3D&reserved=0
> > +$schema:
> > +https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7CWayne_S
> C_Liu%
> >
> +40wiwynn.com%7Cd2e29aed8bdc47a743e508db8df786ac%7Cda6e0628fc834
> caf9dd
> >
> +273061cbab167%7C0%7C0%7C638259866495880680%7CUnknown%7CTWFp
> bGZsb3d8ey
> >
> +JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C30
> >
> +00%7C%7C%7C&sdata=fAA2CUAxdK6MJugvQ1ZRZ1hvB%2FfS%2B8SEOwQ3R
> Z2HEXo%3D&
> > +reserved=0
> > +
> > +title: LTC4286 power monitors
> > +
> > +maintainers:
> > + - Delphine CC Chiu <[email protected]>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - lltc,ltc4286
> > + - lltc,ltc4287
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + vrange_select_25p6:
>
> Needs a vendor prefix and don't use '_'.

We will revise as adi,vrange-select-25p6

>
> > + description:
> > + This property is a bool parameter to represent the
>
> We have types, don't define the type in free form text.

We will revise as below
description:
Specifies which voltage range is used, 25.6 or 102.4.
type: boolean

>
> > + voltage range is 25.6 or not for this chip.
> > +
> > + shunt-resistor-micro-ohms:
> > + description:
> > + Resistor value in micro-Ohm
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - shunt-resistor-micro-ohms
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + power-sensor@40 {
> > + compatible = "lltc,ltc4286";
> > + reg = <0x40>;
> > + vrange_select_25p6;
> > + shunt-resistor-micro-ohms = <300>;
> > + };
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS index
> > d516295978a4..7c1cb9bd4f45 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -12344,6 +12344,15 @@ S: Maintained
> > F: Documentation/hwmon/ltc4261.rst
> > F: drivers/hwmon/ltc4261.c
> >
> > +LTC4286 HARDWARE MONITOR DRIVER
> > +M: Delphine CC Chiu <[email protected]>
> > +L: [email protected]
> > +S: Maintained
> > +F: Documentation/devicetree/bindings/hwmon/lltc,ltc4286.yaml
> > +F: drivers/hwmon/pmbus/Kconfig
> > +F: drivers/hwmon/pmbus/Makefile
> > +F: drivers/hwmon/pmbus/ltc4286.c
> > +
> > LTC4306 I2C MULTIPLEXER DRIVER
> > M: Michael Hennerich <[email protected]>
> > L: [email protected]
> > --
> > 2.25.1
> >