2023-07-27 17:29:44

by Yuanjun Gong

Subject: [PATCH 1/1] nvmem: imx-ocotp: fix value check in imx_ocotp_probe()

in imx_ocotp_probe(), check the return value of clk_prepare_enable()
and return the error code if clk_prepare_enable() returns an
unexpected value.

Fixes: c33c585f1b3a ("nvmem: imx-ocotp: reset error status on probe")
Signed-off-by: Yuanjun Gong <[email protected]>
---
drivers/nvmem/imx-ocotp.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
index ab556c011f3e..c4d604256862 100644
--- a/drivers/nvmem/imx-ocotp.c
+++ b/drivers/nvmem/imx-ocotp.c
@@ -600,6 +600,7 @@ static int imx_ocotp_probe(struct platform_device *pdev)
struct device *dev = &pdev->dev;
struct ocotp_priv *priv;
struct nvmem_device *nvmem;
+ int ret;

priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
@@ -623,7 +624,9 @@ static int imx_ocotp_probe(struct platform_device *pdev)

priv->config = &imx_ocotp_nvmem_config;

- clk_prepare_enable(priv->clk);
+ ret = clk_prepare_enable(priv->clk);
+ if (ret)
+ return ret;
imx_ocotp_clr_err_if_set(priv);
clk_disable_unprepare(priv->clk);

--
2.17.1

2023-07-27 18:04:28

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/1] nvmem: imx-ocotp: fix value check in imx_ocotp_probe()

On Fri, Jul 28, 2023 at 01:04:14AM +0800, Yuanjun Gong wrote:
> in imx_ocotp_probe(), check the return value of clk_prepare_enable()
> and return the error code if clk_prepare_enable() returns an
> unexpected value.
>
> Fixes: c33c585f1b3a ("nvmem: imx-ocotp: reset error status on probe")
> Signed-off-by: Yuanjun Gong <[email protected]>

Why isn't this also properly tagged to go to the stable kernel releases?

I need to write a bot to catch these things...

thanks,

greg k-h