2023-07-28 08:06:21

by 庞苏荣 (Surong Pang)

[permalink] [raw]
Subject: [PATCH] usb: dwc3: gadget: let pm runtime get/put paired

Pm_runtime_get is called when setting pending_events to true.
Pm_runtime_put is needed for pairing with pm_runtime_get.

Signed-off-by: Surong Pang <[email protected]>
---
drivers/usb/dwc3/gadget.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5fd067151fbf..9c835c5f9928 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -4720,5 +4720,6 @@ void dwc3_gadget_process_pending_events(struct dwc3 *dwc)
dwc3_interrupt(dwc->irq_gadget, dwc->ev_buf);
dwc->pending_events = false;
enable_irq(dwc->irq_gadget);
+ pm_runtime_put(dwc->dev);
}
}
--
2.17.1



2023-07-28 11:11:00

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: gadget: let pm runtime get/put paired

On Fri, Jul 28, 2023 at 03:39:19PM +0800, Surong Pang wrote:
> Pm_runtime_get is called when setting pending_events to true.
> Pm_runtime_put is needed for pairing with pm_runtime_get.
>
> Signed-off-by: Surong Pang <[email protected]>
> ---
> drivers/usb/dwc3/gadget.c | 1 +
> 1 file changed, 1 insertion(+)

What commit id does this fix?

thanks,

greg k-h

2023-07-29 09:15:33

by surong pang

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: gadget: let pm runtime get/put paired

Dear Greg,
The commit id is aad1a9ff2f53b8d5cde9ea07e1fd7eb7c20171ce

On Fri, Jul 28, 2023 at 6:46 PM Greg KH <[email protected]> wrote:
>
> On Fri, Jul 28, 2023 at 03:39:19PM +0800, Surong Pang wrote:
> > Pm_runtime_get is called when setting pending_events to true.
> > Pm_runtime_put is needed for pairing with pm_runtime_get.
> >
> > Signed-off-by: Surong Pang <[email protected]>
> > ---
> > drivers/usb/dwc3/gadget.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> What commit id does this fix?
>
> thanks,
>
> greg k-h

2023-07-30 11:53:22

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: dwc3: gadget: let pm runtime get/put paired

On Sat, Jul 29, 2023 at 04:43:13PM +0800, surong pang wrote:
> Dear Greg,
> The commit id is aad1a9ff2f53b8d5cde9ea07e1fd7eb7c20171ce

Wonderful, please resend with the proper Fixes: tag in the patch and we
will be glad to queue it up.

thanks,

greg k-h