2023-07-28 11:32:37

by Varshini Rajendran

Subject: [PATCH v3 13/50] dt-bindings: i2c: at91: Add sam9x7 compatible string

Add compatible string for sam9x7.

Signed-off-by: Varshini Rajendran <[email protected]>
---
Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
index 6adedd3ec399..6f3158604d02 100644
--- a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
@@ -27,6 +27,9 @@ properties:
- items:
- const: microchip,sama7g5-i2c
- const: microchip,sam9x60-i2c
+ - items:
+ - const: microchip,sam9x7-i2c
+ - const: microchip,sam9x60-i2c

reg:
maxItems: 1
@@ -84,6 +87,7 @@ allOf:
- atmel,sama5d4-i2c
- atmel,sama5d2-i2c
- microchip,sam9x60-i2c
+ - microchip,sam9x7-i2c
- microchip,sama7g5-i2c
then:
properties:
--
2.25.1

2023-07-28 12:14:46

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 13/50] dt-bindings: i2c: at91: Add sam9x7 compatible string

On 28/07/2023 12:25, Varshini Rajendran wrote:
> Add compatible string for sam9x7.
>
> Signed-off-by: Varshini Rajendran <[email protected]>
> ---
> Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
> index 6adedd3ec399..6f3158604d02 100644
> --- a/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/atmel,at91sam-i2c.yaml
> @@ -27,6 +27,9 @@ properties:
> - items:
> - const: microchip,sama7g5-i2c
> - const: microchip,sam9x60-i2c
> + - items:
> + - const: microchip,sam9x7-i2c

Make it an enum with sama7g5.

> + - const: microchip,sam9x60-i2c
>
> reg:
> maxItems: 1
> @@ -84,6 +87,7 @@ allOf:
> - atmel,sama5d4-i2c
> - atmel,sama5d2-i2c
> - microchip,sam9x60-i2c
> + - microchip,sam9x7-i2c

This shouldn't be needed.

> - microchip,sama7g5-i2c
> then:
> properties:

Best regards,
Krzysztof