2023-07-28 11:27:49

by Varshini Rajendran

Subject: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

Document sam9x7 compatible for usb ohci.

Signed-off-by: Varshini Rajendran <[email protected]>
---
Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
index be268e23ca79..a2490759f694 100644
--- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
+++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
@@ -57,6 +57,12 @@ properties:
- nxp,ohci-nxp
- st,spear600-ohci
- const: usb-ohci
+ - items:
+ - enum:
+ - microchip,sam9x7-ohci
+ - enum:
+ - atmel,at91rm9200-ohci
+ - const: usb-ohci

reg:
maxItems: 1
--
2.25.1

2023-07-28 12:13:41

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

On 28/07/2023 12:28, Varshini Rajendran wrote:
> Document sam9x7 compatible for usb ohci.
>
> Signed-off-by: Varshini Rajendran <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> index be268e23ca79..a2490759f694 100644
> --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> @@ -57,6 +57,12 @@ properties:
> - nxp,ohci-nxp
> - st,spear600-ohci
> - const: usb-ohci
> + - items:
> + - enum:
> + - microchip,sam9x7-ohci
> + - enum:

That's not an enum. You cannot have here different compatibles.

> + - atmel,at91rm9200-ohci
> + - const: usb-ohci
>
> reg:
> maxItems: 1

Best regards,
Krzysztof

2023-07-28 20:00:51

by Rob Herring (Arm)

Subject: Re: [PATCH v3 33/50] dt-bindings: usb: add sam9x7

On Fri, Jul 28, 2023 at 01:48:01PM +0200, Krzysztof Kozlowski wrote:
> On 28/07/2023 12:28, Varshini Rajendran wrote:
> > Document sam9x7 compatible for usb ohci.
> >
> > Signed-off-by: Varshini Rajendran <[email protected]>
> > ---
> > Documentation/devicetree/bindings/usb/generic-ohci.yaml | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > index be268e23ca79..a2490759f694 100644
> > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml
> > @@ -57,6 +57,12 @@ properties:
> > - nxp,ohci-nxp
> > - st,spear600-ohci
> > - const: usb-ohci
> > + - items:
> > + - enum:
> > + - microchip,sam9x7-ohci
> > + - enum:
>
> That's not an enum. You cannot have here different compatibles.
>
> > + - atmel,at91rm9200-ohci
> > + - const: usb-ohci

As mentioned elsewhere, you aren't really compatible having custom
properties. If you are adding this here, then stuff should be removed
from the .txt binding. You need to sort out this mess and the existing
warnings with 'usb-ohci' in Atmel dts files before adding on to it.

Rob