2023-07-28 14:20:22

by Yue Haibing

[permalink] [raw]
Subject: [PATCH net-next] devlink: Remove unused extern declaration devlink_port_region_destroy()

devlink_port_region_destroy() is never implemented since
commit 544e7c33ec2f ("net: devlink: Add support for port regions").

Signed-off-by: Yue Haibing <[email protected]>
---
include/net/devlink.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/net/devlink.h b/include/net/devlink.h
index 0cdb4b16e5b5..a1a8e1b6e7df 100644
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -1790,8 +1790,6 @@ devlink_port_region_create(struct devlink_port *port,
u32 region_max_snapshots, u64 region_size);
void devl_region_destroy(struct devlink_region *region);
void devlink_region_destroy(struct devlink_region *region);
-void devlink_port_region_destroy(struct devlink_region *region);
-
int devlink_region_snapshot_id_get(struct devlink *devlink, u32 *id);
void devlink_region_snapshot_id_put(struct devlink *devlink, u32 id);
int devlink_region_snapshot_create(struct devlink_region *region,
--
2.34.1



2023-07-29 12:00:58

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next] devlink: Remove unused extern declaration devlink_port_region_destroy()

On Fri, Jul 28, 2023 at 09:21:13PM +0800, Yue Haibing wrote:
> devlink_port_region_destroy() is never implemented since
> commit 544e7c33ec2f ("net: devlink: Add support for port regions").
>
> Signed-off-by: Yue Haibing <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2023-07-31 22:29:58

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next] devlink: Remove unused extern declaration devlink_port_region_destroy()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Fri, 28 Jul 2023 21:21:13 +0800 you wrote:
> devlink_port_region_destroy() is never implemented since
> commit 544e7c33ec2f ("net: devlink: Add support for port regions").
>
> Signed-off-by: Yue Haibing <[email protected]>
> ---
> include/net/devlink.h | 2 --
> 1 file changed, 2 deletions(-)

Here is the summary with links:
- [net-next] devlink: Remove unused extern declaration devlink_port_region_destroy()
https://git.kernel.org/netdev/net-next/c/2628d40899d1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html