2023-07-28 13:46:20

by Yue Haibing

Subject: [PATCH -next] i2c: s3c2410: Remove unused extern declarations

commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind
s3c_i2c(*)_set_platdata().
commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
leave s5p_i2c_hdmiphy_set_platdata() declaration.
And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
leave s3c_i2c(*)_cfg_gpio() alone.

Signed-off-by: Yue Haibing <[email protected]>
---
include/linux/platform_data/i2c-s3c2410.h | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/include/linux/platform_data/i2c-s3c2410.h b/include/linux/platform_data/i2c-s3c2410.h
index 550746715139..c8c3146c34ea 100644
--- a/include/linux/platform_data/i2c-s3c2410.h
+++ b/include/linux/platform_data/i2c-s3c2410.h
@@ -52,23 +52,10 @@ struct s3c2410_platform_i2c {
*/
extern void s3c_i2c0_set_platdata(struct s3c2410_platform_i2c *i2c);
extern void s3c_i2c1_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s3c_i2c2_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s3c_i2c3_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s3c_i2c4_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s3c_i2c5_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s3c_i2c6_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s3c_i2c7_set_platdata(struct s3c2410_platform_i2c *i2c);
-extern void s5p_i2c_hdmiphy_set_platdata(struct s3c2410_platform_i2c *i2c);

/* defined by architecture to configure gpio */
extern void s3c_i2c0_cfg_gpio(struct platform_device *dev);
extern void s3c_i2c1_cfg_gpio(struct platform_device *dev);
-extern void s3c_i2c2_cfg_gpio(struct platform_device *dev);
-extern void s3c_i2c3_cfg_gpio(struct platform_device *dev);
-extern void s3c_i2c4_cfg_gpio(struct platform_device *dev);
-extern void s3c_i2c5_cfg_gpio(struct platform_device *dev);
-extern void s3c_i2c6_cfg_gpio(struct platform_device *dev);
-extern void s3c_i2c7_cfg_gpio(struct platform_device *dev);

extern struct s3c2410_platform_i2c default_i2c_data;

--
2.34.1

2023-08-05 22:44:14

by Andi Shyti

Subject: Re: [PATCH -next] i2c: s3c2410: Remove unused extern declarations

Hi Yue,

On Fri, Jul 28, 2023 at 09:23:18PM +0800, Yue Haibing wrote:
> commit 0d297df03890 ("ARM: s3c: simplify platform code") left behind
> s3c_i2c(*)_set_platdata().
> commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
> leave s5p_i2c_hdmiphy_set_platdata() declaration.
> And commit bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
> leave s3c_i2c(*)_cfg_gpio() alone.

I don't understand anything from the commit message here.

How about:

"
After some cleanups[*] certain s3c_i2c(*)_cfg_gpio() prototypes
have become unused. Remove them.

[*] 0d297df03890 ("ARM: s3c: simplify platform code")
d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
bad1e6aadd17 ("ARM: SAMSUNG: Cleanup plat-samsung/devs.c and devs.h")
"

> Signed-off-by: Yue Haibing <[email protected]>

Reviewed-by: Andi Shyti <[email protected]>

which branch should this go? Samsung or i2c?

Andi