2023-07-28 16:16:05

by Christian Göttsche

Subject: [PATCH v2 4/9] selinux: avoid implicit conversions in mls code

Use u32 for ebitmap bits.

Use char for the default range of a class.

Signed-off-by: Christian Göttsche <[email protected]>
---
v2: avoid declarations in init-clauses of for loops
---
security/selinux/ss/mls.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
index b2c6c846ea03..cd38f5913b63 100644
--- a/security/selinux/ss/mls.c
+++ b/security/selinux/ss/mls.c
@@ -45,7 +45,7 @@ int mls_compute_context_len(struct policydb *p, struct context *context)

len = 1; /* for the beginning ":" */
for (l = 0; l < 2; l++) {
- int index_sens = context->range.level[l].sens;
+ u32 index_sens = context->range.level[l].sens;
len += strlen(sym_name(p, SYM_LEVELS, index_sens - 1));

/* categories */
@@ -240,7 +240,8 @@ int mls_context_to_sid(struct policydb *pol,
char *sensitivity, *cur_cat, *next_cat, *rngptr;
struct level_datum *levdatum;
struct cat_datum *catdatum, *rngdatum;
- int l, rc, i;
+ u32 i;
+ int l, rc;
char *rangep[2];

if (!pol->mls_enabled) {
@@ -451,7 +452,8 @@ int mls_convert_context(struct policydb *oldp,
struct level_datum *levdatum;
struct cat_datum *catdatum;
struct ebitmap_node *node;
- int l, i;
+ u32 i;
+ int l;

if (!oldp->mls_enabled || !newp->mls_enabled)
return 0;
@@ -495,7 +497,7 @@ int mls_compute_sid(struct policydb *p,
struct range_trans rtr;
struct mls_range *r;
struct class_datum *cladatum;
- int default_range = 0;
+ char default_range = 0;

if (!p->mls_enabled)
return 0;
--
2.40.1

2023-08-04 04:08:30

by Paul Moore

Subject: Re: [PATCH v2 4/9] selinux: avoid implicit conversions in mls code

On Jul 28, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <[email protected]> wrote:
>
> Use u32 for ebitmap bits.
>
> Use char for the default range of a class.
>
> Signed-off-by: Christian Göttsche <[email protected]>
> ---
> v2: avoid declarations in init-clauses of for loops
> ---
> security/selinux/ss/mls.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)

Merged into selinux/next, thanks.

--
paul-moore.com