2023-07-29 12:56:27

by Yue Haibing

[permalink] [raw]
Subject: [PATCH net-next] rxrpc: Remove unused function declarations

commit 3cec055c5695 ("rxrpc: Don't hold a ref for connection workqueue")
left behind these declarations.

Signed-off-by: Yue Haibing <[email protected]>
---
net/rxrpc/ar-internal.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/rxrpc/ar-internal.h b/net/rxrpc/ar-internal.h
index e8e14c6f904d..a22f4ae849ca 100644
--- a/net/rxrpc/ar-internal.h
+++ b/net/rxrpc/ar-internal.h
@@ -834,7 +834,6 @@ bool rxrpc_new_incoming_call(struct rxrpc_local *local,
struct rxrpc_connection *conn,
struct sockaddr_rxrpc *peer_srx,
struct sk_buff *skb);
-void rxrpc_accept_incoming_calls(struct rxrpc_local *);
int rxrpc_user_charge_accept(struct rxrpc_sock *, unsigned long);

/*
@@ -954,7 +953,6 @@ void rxrpc_connect_client_calls(struct rxrpc_local *local);
void rxrpc_expose_client_call(struct rxrpc_call *);
void rxrpc_disconnect_client_call(struct rxrpc_bundle *, struct rxrpc_call *);
void rxrpc_deactivate_bundle(struct rxrpc_bundle *bundle);
-void rxrpc_put_client_conn(struct rxrpc_connection *, enum rxrpc_conn_trace);
void rxrpc_discard_expired_client_conns(struct rxrpc_local *local);
void rxrpc_clean_up_local_conns(struct rxrpc_local *);

--
2.34.1



2023-07-30 19:44:07

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH net-next] rxrpc: Remove unused function declarations

On Sat, Jul 29, 2023 at 08:23:27PM +0800, Yue Haibing wrote:
> commit 3cec055c5695 ("rxrpc: Don't hold a ref for connection workqueue")
> left behind these declarations.

It may bot be important, but the while above commit seems for
rxrpc_put_client_conn, perhaps for rxrpc_accept_incoming_calls it should
be:

248f219cb8bc ("rxrpc: Rewrite the data and ack handling code")

Patch looks otherwise fine by me.

Reviewed-by: Simon Horman <[email protected]>