2023-07-25 15:03:18

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: imx8mm-phycore: drop uncorrect vselect-en

There is no "vselect-en" property, neither in the bindings nor in the
Linux driver:

imx8mm-phyboard-polis-rdk.dtb: pmic@8: regulators:ldo2: Unevaluated properties are not allowed ('vselect-en' was unexpected)

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
index 404f7de0b722..6069678244f3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
@@ -151,7 +151,6 @@ reg_nvcc_sd2: ldo2 {
regulator-max-microvolt = <3300000>;
regulator-min-microvolt = <1800000>;
regulator-name = "NVCC_SD2 (LDO2)";
- vselect-en;

regulator-state-mem {
regulator-off-in-suspend;
--
2.34.1



2023-07-26 06:58:47

by Yannic Moog

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mm-phycore: drop uncorrect vselect-en

On Tue, 2023-07-25 at 16:26 +0200, Krzysztof Kozlowski wrote:
> There is no "vselect-en" property, neither in the bindings nor in the
> Linux driver:
>
>   imx8mm-phyboard-polis-rdk.dtb: pmic@8: regulators:ldo2: Unevaluated
> properties are not allowed ('vselect-en' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Yannic Moog <[email protected]>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> index 404f7de0b722..6069678244f3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-phycore-som.dtsi
> @@ -151,7 +151,6 @@ reg_nvcc_sd2: ldo2 {
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-name = "NVCC_SD2 (LDO2)";
> -                               vselect-en;
>  
>                                 regulator-state-mem {
>                                         regulator-off-in-suspend;

2023-07-30 14:13:59

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: imx8mm-phycore: drop uncorrect vselect-en

On Tue, Jul 25, 2023 at 04:26:53PM +0200, Krzysztof Kozlowski wrote:
> There is no "vselect-en" property, neither in the bindings nor in the
> Linux driver:
>
> imx8mm-phyboard-polis-rdk.dtb: pmic@8: regulators:ldo2: Unevaluated properties are not allowed ('vselect-en' was unexpected)
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied, thanks!