Use device_create_bin_file() instead of sysfs_create_bin_file()
to avoid having to access the device kobject.
Tested on a ASUS PRIME B650-PLUS.
Reviewed-by: Thomas Weißschuh <[email protected]>
Tested-by: Thomas Weißschuh <[email protected]>
Signed-off-by: Armin Wolf <[email protected]>
---
Changes since v1:
- add Reviewed-by and Tested-by tags
---
drivers/platform/x86/wmi-bmof.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/wmi-bmof.c b/drivers/platform/x86/wmi-bmof.c
index 80137afb9753..d0516cacfcb5 100644
--- a/drivers/platform/x86/wmi-bmof.c
+++ b/drivers/platform/x86/wmi-bmof.c
@@ -75,7 +75,7 @@ static int wmi_bmof_probe(struct wmi_device *wdev, const void *context)
priv->bmof_bin_attr.read = read_bmof;
priv->bmof_bin_attr.size = priv->bmofdata->buffer.length;
- ret = sysfs_create_bin_file(&wdev->dev.kobj, &priv->bmof_bin_attr);
+ ret = device_create_bin_file(&wdev->dev, &priv->bmof_bin_attr);
if (ret)
goto err_free;
@@ -90,7 +90,7 @@ static void wmi_bmof_remove(struct wmi_device *wdev)
{
struct bmof_priv *priv = dev_get_drvdata(&wdev->dev);
- sysfs_remove_bin_file(&wdev->dev.kobj, &priv->bmof_bin_attr);
+ device_remove_bin_file(&wdev->dev, &priv->bmof_bin_attr);
kfree(priv->bmofdata);
}
--
2.39.2
The WMI Binary MOF driver is important for the development
of modern WMI drivers, i am willing to maintain it.
Also fix the mailing list address.
Signed-off-by: Armin Wolf <[email protected]>
---
Chnages since v2:
- Use correct email address
Changes since v1:
- Add Thomas Weißschuh as reviewer
---
MAINTAINERS | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 426d3be71da2..2740849d0f87 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -22954,8 +22954,10 @@ S: Odd fixes
F: drivers/net/wireless/legacy/wl3501*
WMI BINARY MOF DRIVER
-L: [email protected]
-S: Orphan
+M: Armin Wolf <[email protected]>
+R: Thomas Weißschuh <[email protected]>
+L: [email protected]
+S: Maintained
F: Documentation/ABI/stable/sysfs-platform-wmi-bmof
F: Documentation/wmi/devices/wmi-bmof.rst
F: drivers/platform/x86/wmi-bmof.c
--
2.39.2
Hi,
On 7/30/23 22:45, Armin Wolf wrote:
> Use device_create_bin_file() instead of sysfs_create_bin_file()
> to avoid having to access the device kobject.
>
> Tested on a ASUS PRIME B650-PLUS.
>
> Reviewed-by: Thomas Weißschuh <[email protected]>
> Tested-by: Thomas Weißschuh <[email protected]>
> Signed-off-by: Armin Wolf <[email protected]>
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> Changes since v1:
> - add Reviewed-by and Tested-by tags
> ---
> drivers/platform/x86/wmi-bmof.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/wmi-bmof.c b/drivers/platform/x86/wmi-bmof.c
> index 80137afb9753..d0516cacfcb5 100644
> --- a/drivers/platform/x86/wmi-bmof.c
> +++ b/drivers/platform/x86/wmi-bmof.c
> @@ -75,7 +75,7 @@ static int wmi_bmof_probe(struct wmi_device *wdev, const void *context)
> priv->bmof_bin_attr.read = read_bmof;
> priv->bmof_bin_attr.size = priv->bmofdata->buffer.length;
>
> - ret = sysfs_create_bin_file(&wdev->dev.kobj, &priv->bmof_bin_attr);
> + ret = device_create_bin_file(&wdev->dev, &priv->bmof_bin_attr);
> if (ret)
> goto err_free;
>
> @@ -90,7 +90,7 @@ static void wmi_bmof_remove(struct wmi_device *wdev)
> {
> struct bmof_priv *priv = dev_get_drvdata(&wdev->dev);
>
> - sysfs_remove_bin_file(&wdev->dev.kobj, &priv->bmof_bin_attr);
> + device_remove_bin_file(&wdev->dev, &priv->bmof_bin_attr);
> kfree(priv->bmofdata);
> }
>
> --
> 2.39.2
>