2023-07-23 05:06:55

by Zhang Shurong

Subject: [PATCH] serial: st-asc: Fix to check return value of platform_get_irq() in asc_init_port()

The platform_get_irq might be failed and return a negative result. So
there should have an error handling code.

Fixed this by adding an error handling code.

Fixes: c4b058560762 ("serial:st-asc: Add ST ASC driver.")
Signed-off-by: Zhang Shurong <[email protected]>
---
drivers/tty/serial/st-asc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index aa471c9c24d9..2f1807fa9bdb 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -688,9 +688,13 @@ static int asc_init_port(struct asc_port *ascport,
port->ops = &asc_uart_ops;
port->fifosize = ASC_FIFO_SIZE;
port->dev = &pdev->dev;
- port->irq = platform_get_irq(pdev, 0);
port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_ST_ASC_CONSOLE);

+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0)
+ return ret;
+ port->irq = ret;
+
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
port->membase = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(port->membase))
--
2.41.0

2023-07-30 13:47:53

by Greg Kroah-Hartman

Subject: Re: [PATCH] serial: st-asc: Fix to check return value of platform_get_irq() in asc_init_port()

On Sun, Jul 23, 2023 at 12:28:47PM +0800, Zhang Shurong wrote:
> The platform_get_irq might be failed and return a negative result. So
> there should have an error handling code.
>
> Fixed this by adding an error handling code.
>
> Fixes: c4b058560762 ("serial:st-asc: Add ST ASC driver.")
> Signed-off-by: Zhang Shurong <[email protected]>
> ---
> drivers/tty/serial/st-asc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
> index aa471c9c24d9..2f1807fa9bdb 100644
> --- a/drivers/tty/serial/st-asc.c
> +++ b/drivers/tty/serial/st-asc.c
> @@ -688,9 +688,13 @@ static int asc_init_port(struct asc_port *ascport,
> port->ops = &asc_uart_ops;
> port->fifosize = ASC_FIFO_SIZE;
> port->dev = &pdev->dev;
> - port->irq = platform_get_irq(pdev, 0);
> port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_ST_ASC_CONSOLE);
>
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0)
> + return ret;
> + port->irq = ret;
> +
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> port->membase = devm_ioremap_resource(&pdev->dev, res);
> if (IS_ERR(port->membase))
> --
> 2.41.0
>

Does not apply to my tty-next tree :(