2023-07-31 02:02:56

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] RDMA/irdma: Fix one kernel-doc comment

Remove description of @free_hwcqp in irdma_destroy_cqp().
to silence the warning:

drivers/infiniband/hw/irdma/hw.c:580: warning: Excess function parameter 'free_hwcqp' description in 'irdma_destroy_cqp'

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6028
Signed-off-by: Yang Li <[email protected]>
---
drivers/infiniband/hw/irdma/hw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
index eaf196985f49..7cbdd5433dba 100644
--- a/drivers/infiniband/hw/irdma/hw.c
+++ b/drivers/infiniband/hw/irdma/hw.c
@@ -571,7 +571,6 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
/**
* irdma_destroy_cqp - destroy control qp
* @rf: RDMA PCI function
- * @free_hwcqp: 1 if hw cqp should be freed
*
* Issue destroy cqp request and
* free the resources associated with the cqp
--
2.20.1.7.g153144c



2023-07-31 03:48:06

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/irdma: Fix one kernel-doc comment



On 7/30/23 18:59, Yang Li wrote:
> Remove description of @free_hwcqp in irdma_destroy_cqp().
> to silence the warning:
>
> drivers/infiniband/hw/irdma/hw.c:580: warning: Excess function parameter 'free_hwcqp' description in 'irdma_destroy_cqp'
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6028
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> drivers/infiniband/hw/irdma/hw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/irdma/hw.c b/drivers/infiniband/hw/irdma/hw.c
> index eaf196985f49..7cbdd5433dba 100644
> --- a/drivers/infiniband/hw/irdma/hw.c
> +++ b/drivers/infiniband/hw/irdma/hw.c
> @@ -571,7 +571,6 @@ static void irdma_destroy_irq(struct irdma_pci_f *rf,
> /**
> * irdma_destroy_cqp - destroy control qp
> * @rf: RDMA PCI function
> - * @free_hwcqp: 1 if hw cqp should be freed
> *
> * Issue destroy cqp request and
> * free the resources associated with the cqp

--
~Randy

2023-07-31 08:23:10

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/irdma: Fix one kernel-doc comment


On Mon, 31 Jul 2023 09:59:15 +0800, Yang Li wrote:
> Remove description of @free_hwcqp in irdma_destroy_cqp().
> to silence the warning:
>
> drivers/infiniband/hw/irdma/hw.c:580: warning: Excess function parameter 'free_hwcqp' description in 'irdma_destroy_cqp'
>
>

Applied, thanks!

[1/1] RDMA/irdma: Fix one kernel-doc comment
https://git.kernel.org/rdma/rdma/c/d43ea9c3d52f2e

Best regards,
--
Leon Romanovsky <[email protected]>