2023-07-31 15:08:34

by Yue Haibing

Subject: [PATCH -next] RDMA/hns: Remove unused function declarations

commit b16f8188472e ("RDMA/hns: Refactor eq code for hip06")
left behind hns_roce_cleanup_eq_table().
And commit 773f841ab1ae ("RDMA/hns: Avoid filling sgid index when modifying QP to RTR")
leave hns_get_gid_index() unused.

Signed-off-by: Yue Haibing <[email protected]>
---
drivers/infiniband/hw/hns/hns_roce_device.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_device.h b/drivers/infiniband/hw/hns/hns_roce_device.h
index 6084c1649000..34e099efaae3 100644
--- a/drivers/infiniband/hw/hns/hns_roce_device.h
+++ b/drivers/infiniband/hw/hns/hns_roce_device.h
@@ -1111,7 +1111,6 @@ int hns_roce_init_qp_table(struct hns_roce_dev *hr_dev);
void hns_roce_init_srq_table(struct hns_roce_dev *hr_dev);
void hns_roce_init_xrcd_table(struct hns_roce_dev *hr_dev);

-void hns_roce_cleanup_eq_table(struct hns_roce_dev *hr_dev);
void hns_roce_cleanup_cq_table(struct hns_roce_dev *hr_dev);
void hns_roce_cleanup_qp_table(struct hns_roce_dev *hr_dev);

@@ -1205,7 +1204,6 @@ void hns_roce_cq_event(struct hns_roce_dev *hr_dev, u32 cqn, int event_type);
void flush_cqe(struct hns_roce_dev *dev, struct hns_roce_qp *qp);
void hns_roce_qp_event(struct hns_roce_dev *hr_dev, u32 qpn, int event_type);
void hns_roce_srq_event(struct hns_roce_dev *hr_dev, u32 srqn, int event_type);
-u8 hns_get_gid_index(struct hns_roce_dev *hr_dev, u32 port, int gid_index);
void hns_roce_handle_device_err(struct hns_roce_dev *hr_dev);
int hns_roce_init(struct hns_roce_dev *hr_dev);
void hns_roce_exit(struct hns_roce_dev *hr_dev);
--
2.34.1

2023-07-31 20:01:45

by Jason Gunthorpe

Subject: Re: [PATCH -next] RDMA/hns: Remove unused function declarations

On Mon, Jul 31, 2023 at 09:59:16PM +0800, Yue Haibing wrote:
> commit b16f8188472e ("RDMA/hns: Refactor eq code for hip06")
> left behind hns_roce_cleanup_eq_table().
> And commit 773f841ab1ae ("RDMA/hns: Avoid filling sgid index when modifying QP to RTR")
> leave hns_get_gid_index() unused.
>
> Signed-off-by: Yue Haibing <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_device.h | 2 --
> 1 file changed, 2 deletions(-)

Applied to for-next, thanks

Jason