2023-08-01 03:03:37

by Ran Sun

Subject: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

Fix the following errors reported by checkpatch:

ERROR: open brace '{' following enum go on the same line

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
index 075c0094da9c..1ba9b5fe2a5d 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
@@ -385,8 +385,7 @@ struct vega20_odn_data {
struct vega20_odn_temp_table odn_temp_table;
};

-enum OD8_FEATURE_ID
-{
+enum OD8_FEATURE_ID {
OD8_GFXCLK_LIMITS = 1 << 0,
OD8_GFXCLK_CURVE = 1 << 1,
OD8_UCLK_MAX = 1 << 2,
@@ -399,8 +398,7 @@ enum OD8_FEATURE_ID
OD8_FAN_ZERO_RPM_CONTROL = 1 << 9
};

-enum OD8_SETTING_ID
-{
+enum OD8_SETTING_ID {
OD8_SETTING_GFXCLK_FMIN = 0,
OD8_SETTING_GFXCLK_FMAX,
OD8_SETTING_GFXCLK_FREQ1,
--
2.17.1

2023-08-01 10:17:45

by Evan Quan

Subject: RE: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

[AMD Official Use Only - General]

Reviewed-by: Evan Quan <[email protected]>

> -----Original Message-----
> From: amd-gfx <[email protected]> On Behalf Of Ran
> Sun
> Sent: Tuesday, August 1, 2023 10:39 AM
> To: Deucher, Alexander <[email protected]>; [email protected];
> [email protected]
> Cc: Ran Sun <[email protected]>; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following enum go on the same line
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> index 075c0094da9c..1ba9b5fe2a5d 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> @@ -385,8 +385,7 @@ struct vega20_odn_data {
> struct vega20_odn_temp_table odn_temp_table;
> };
>
> -enum OD8_FEATURE_ID
> -{
> +enum OD8_FEATURE_ID {
> OD8_GFXCLK_LIMITS = 1 << 0,
> OD8_GFXCLK_CURVE = 1 << 1,
> OD8_UCLK_MAX = 1 << 2,
> @@ -399,8 +398,7 @@ enum OD8_FEATURE_ID
> OD8_FAN_ZERO_RPM_CONTROL = 1 << 9
> };
>
> -enum OD8_SETTING_ID
> -{
> +enum OD8_SETTING_ID {
> OD8_SETTING_GFXCLK_FMIN = 0,
> OD8_SETTING_GFXCLK_FMAX,
> OD8_SETTING_GFXCLK_FREQ1,
> --
> 2.17.1

2023-08-07 16:57:16

by Alex Deucher

Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h

Applied. Thanks!

On Tue, Aug 1, 2023 at 5:25 AM Quan, Evan <[email protected]> wrote:
>
> [AMD Official Use Only - General]
>
> Reviewed-by: Evan Quan <[email protected]>
>
> > -----Original Message-----
> > From: amd-gfx <[email protected]> On Behalf Of Ran
> > Sun
> > Sent: Tuesday, August 1, 2023 10:39 AM
> > To: Deucher, Alexander <[email protected]>; [email protected];
> > [email protected]
> > Cc: Ran Sun <[email protected]>; [email protected];
> > [email protected]; [email protected]
> > Subject: [PATCH] drm/amd/pm: Clean up errors in vega20_hwmgr.h
> >
> > Fix the following errors reported by checkpatch:
> >
> > ERROR: open brace '{' following enum go on the same line
> >
> > Signed-off-by: Ran Sun <[email protected]>
> > ---
> > drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h | 6 ++----
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> > b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> > index 075c0094da9c..1ba9b5fe2a5d 100644
> > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_hwmgr.h
> > @@ -385,8 +385,7 @@ struct vega20_odn_data {
> > struct vega20_odn_temp_table odn_temp_table;
> > };
> >
> > -enum OD8_FEATURE_ID
> > -{
> > +enum OD8_FEATURE_ID {
> > OD8_GFXCLK_LIMITS = 1 << 0,
> > OD8_GFXCLK_CURVE = 1 << 1,
> > OD8_UCLK_MAX = 1 << 2,
> > @@ -399,8 +398,7 @@ enum OD8_FEATURE_ID
> > OD8_FAN_ZERO_RPM_CONTROL = 1 << 9
> > };
> >
> > -enum OD8_SETTING_ID
> > -{
> > +enum OD8_SETTING_ID {
> > OD8_SETTING_GFXCLK_FMIN = 0,
> > OD8_SETTING_GFXCLK_FMAX,
> > OD8_SETTING_GFXCLK_FREQ1,
> > --
> > 2.17.1
>