2023-08-01 19:25:41

by Hugo Villeneuve

Subject: [PATCH] rtc: pcf2127: remove unused function argument

From: Hugo Villeneuve <[email protected]>

Fixes the following W=1 kernel build warning(s):

drivers/rtc/rtc-pcf2127.c: In function ‘pcf2127_probe’:
drivers/rtc/rtc-pcf2127.c:635:32: warning: unused parameter ‘name’ [-Wunused-parameter]
635 | int alarm_irq, const char *name, bool is_pcf2127)
| ~~~~~~~~~~~~^~~~

Signed-off-by: Hugo Villeneuve <[email protected]>
---
drivers/rtc/rtc-pcf2127.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
index 3387afe93417..14f59e4535e8 100644
--- a/drivers/rtc/rtc-pcf2127.c
+++ b/drivers/rtc/rtc-pcf2127.c
@@ -1103,7 +1103,7 @@ static int pcf2127_configure_interrupt_pins(struct device *dev)
}

static int pcf2127_probe(struct device *dev, struct regmap *regmap,
- int alarm_irq, const char *name, const struct pcf21xx_config *config)
+ int alarm_irq, const struct pcf21xx_config *config)
{
struct pcf2127 *pcf2127;
int ret = 0;
@@ -1402,8 +1402,7 @@ static int pcf2127_i2c_probe(struct i2c_client *client)
return PTR_ERR(regmap);
}

- return pcf2127_probe(&client->dev, regmap, client->irq,
- pcf2127_i2c_driver.driver.name, variant);
+ return pcf2127_probe(&client->dev, regmap, client->irq, variant);
}

static struct i2c_driver pcf2127_i2c_driver = {
@@ -1475,9 +1474,7 @@ static int pcf2127_spi_probe(struct spi_device *spi)
return PTR_ERR(regmap);
}

- return pcf2127_probe(&spi->dev, regmap, spi->irq,
- pcf2127_spi_driver.driver.name,
- variant);
+ return pcf2127_probe(&spi->dev, regmap, spi->irq, variant);
}

static const struct spi_device_id pcf2127_spi_id[] = {

base-commit: 3c87b351809f220294aec3c0df7b078ff5c5b15b
prerequisite-patch-id: 9cbdafa114f5dc7490862c8009f781258c9f9884
--
2.30.2

2023-08-19 20:47:46

by Alexandre Belloni

Subject: Re: [PATCH] rtc: pcf2127: remove unused function argument

On Tue, 01 Aug 2023 15:04:32 -0400, Hugo Villeneuve wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/rtc/rtc-pcf2127.c: In function ‘pcf2127_probe’:
> drivers/rtc/rtc-pcf2127.c:635:32: warning: unused parameter ‘name’ [-Wunused-parameter]
> 635 | int alarm_irq, const char *name, bool is_pcf2127)
> | ~~~~~~~~~~~~^~~~
>
> [...]

Applied, thanks!

[1/1] rtc: pcf2127: remove unused function argument
commit: 58dffa96e62ccf30ecba718f124ce822ddc1150a

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com