2023-08-02 07:21:47

by Nikita Travkin

Subject: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE

The driver can be built as a module, however the lack of the
MODULE_DEVICE_TABLE macro prevents it from being automatically probed
from the DT in such case.

Add the missed macro to make sure the module can load automatically.

Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
Signed-off-by: Nikita Travkin <[email protected]>
---
drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
index 0583360b1280..ea5a85779382 100644
--- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
+++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
@@ -567,6 +567,7 @@ static const struct of_device_id s6d7aa0_of_match[] = {
},
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, s6d7aa0_of_match);

static struct mipi_dsi_driver s6d7aa0_driver = {
.probe = s6d7aa0_probe,

---
base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5
change-id: 20230802-gt5-panel-dtable-d9d6ca407f26

Best regards,
--
Nikita Travkin <[email protected]>

2023-08-02 08:59:11

by Neil Armstrong

Subject: Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE

On 02/08/2023 08:41, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
>
> Add the missed macro to make sure the module can load automatically.
>
> Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
> Signed-off-by: Nikita Travkin <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> index 0583360b1280..ea5a85779382 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c
> @@ -567,6 +567,7 @@ static const struct of_device_id s6d7aa0_of_match[] = {
> },
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, s6d7aa0_of_match);
>
> static struct mipi_dsi_driver s6d7aa0_driver = {
> .probe = s6d7aa0_probe,
>
> ---
> base-commit: 626c67169f9972fffcdf3bc3864de421f162ebf5
> change-id: 20230802-gt5-panel-dtable-d9d6ca407f26
>
> Best regards,

Reviewed-by: Neil Armstrong <[email protected]>

2023-08-02 09:14:35

by Artur Weber

Subject: Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE

On 2.08.2023 08:41, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
>
> Add the missed macro to make sure the module can load automatically.
>
> Fixes: 6810bb390282 ("drm/panel: Add Samsung S6D7AA0 panel controller driver")
> Signed-off-by: Nikita Travkin <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Artur Weber <[email protected]>

Best regards
Artur

2023-08-02 09:58:32

by Neil Armstrong

Subject: Re: [PATCH] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE

Hi,

On Wed, 02 Aug 2023 11:41:22 +0500, Nikita Travkin wrote:
> The driver can be built as a module, however the lack of the
> MODULE_DEVICE_TABLE macro prevents it from being automatically probed
> from the DT in such case.
>
> Add the missed macro to make sure the module can load automatically.
>
>
> [...]

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/panel: samsung-s6d7aa0: Add MODULE_DEVICE_TABLE
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=c71b7aa8619a0c9700132d0733e33999fb614339

--
Neil