2023-08-02 02:19:23

by Ran Sun

[permalink] [raw]
Subject: [PATCH] drm/amd/pm: Clean up errors in smu7.h

Fix the following errors reported by checkpatch:

ERROR: open brace '{' following struct go on the same line

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h
index e14072d45918..bfce9087a47f 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h
+++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h
@@ -101,8 +101,7 @@
#define VR_SMIO_PATTERN_2 4
#define VR_STATIC_VOLTAGE 5

-struct SMU7_PIDController
-{
+struct SMU7_PIDController {
uint32_t Ki;
int32_t LFWindupUL;
int32_t LFWindupLL;
@@ -136,8 +135,7 @@ typedef struct SMU7_PIDController SMU7_PIDController;
#define SMU7_VCE_MCLK_HANDSHAKE_DISABLE 0x00010000
#define SMU7_VCE_SCLK_HANDSHAKE_DISABLE 0x00020000

-struct SMU7_Firmware_Header
-{
+struct SMU7_Firmware_Header {
uint32_t Digest[5];
uint32_t Version;
uint32_t HeaderSize;
--
2.17.1



2023-08-07 18:39:55

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/pm: Clean up errors in smu7.h

Applied. Thanks!

On Tue, Aug 1, 2023 at 9:31 PM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h b/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h
> index e14072d45918..bfce9087a47f 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/smu7.h
> @@ -101,8 +101,7 @@
> #define VR_SMIO_PATTERN_2 4
> #define VR_STATIC_VOLTAGE 5
>
> -struct SMU7_PIDController
> -{
> +struct SMU7_PIDController {
> uint32_t Ki;
> int32_t LFWindupUL;
> int32_t LFWindupLL;
> @@ -136,8 +135,7 @@ typedef struct SMU7_PIDController SMU7_PIDController;
> #define SMU7_VCE_MCLK_HANDSHAKE_DISABLE 0x00010000
> #define SMU7_VCE_SCLK_HANDSHAKE_DISABLE 0x00020000
>
> -struct SMU7_Firmware_Header
> -{
> +struct SMU7_Firmware_Header {
> uint32_t Digest[5];
> uint32_t Version;
> uint32_t HeaderSize;
> --
> 2.17.1
>