2023-08-02 04:59:01

by Manivannan Sadhasivam

Subject: [PATCH] scsi: ufs: qcom: Make struct ufs_qcom_bw_table static const

ufs_qcom_bw_table is not modified anywhere. So make it static const so that
it can be placed in read-only memory.

Reported-by: Bart Van Assche <[email protected]>
Closes: https://lore.kernel.org/linux-scsi/[email protected]/
Signed-off-by: Manivannan Sadhasivam <[email protected]>
---
drivers/ufs/host/ufs-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 75a1fd295f34..0341c025e818 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -58,7 +58,7 @@ enum {
MODE_MAX,
};

-struct __ufs_qcom_bw_table {
+static const struct __ufs_qcom_bw_table {
u32 mem_bw;
u32 cfg_bw;
} ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {
--
2.25.1

2023-08-02 16:50:21

by Bart Van Assche

Subject: Re: [PATCH] scsi: ufs: qcom: Make struct ufs_qcom_bw_table static const

On 8/1/23 21:01, Manivannan Sadhasivam wrote:
> ufs_qcom_bw_table is not modified anywhere. So make it static const so that
> it can be placed in read-only memory.
>
> Reported-by: Bart Van Assche <[email protected]>
> Closes: https://lore.kernel.org/linux-scsi/[email protected]/
> Signed-off-by: Manivannan Sadhasivam <[email protected]>
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 75a1fd295f34..0341c025e818 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -58,7 +58,7 @@ enum {
> MODE_MAX,
> };
>
> -struct __ufs_qcom_bw_table {
> +static const struct __ufs_qcom_bw_table {
> u32 mem_bw;
> u32 cfg_bw;
> } ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {

Thanks!

Reviewed-by: Bart Van Assche <[email protected]>

2023-08-08 02:53:32

by Martin K. Petersen

Subject: Re: [PATCH] scsi: ufs: qcom: Make struct ufs_qcom_bw_table static const

Manivannan,

> ufs_qcom_bw_table is not modified anywhere. So make it static const so that
> it can be placed in read-only memory.

Applied to 6.6/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering