2023-08-02 08:02:10

by Ran Sun

Subject: [PATCH] drm/amdgpu: Clean up errors in amdgpu_trace.h

Fix the following errors reported by checkpatch:

ERROR: space required after that ',' (ctx:VxV)
ERROR: "foo* bar" should be "foo *bar"

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
index 525dffbe046a..2fd1bfb35916 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
@@ -432,7 +432,7 @@ TRACE_EVENT(amdgpu_vm_flush,
),
TP_printk("ring=%s, id=%u, hub=%u, pd_addr=%010Lx",
__get_str(ring), __entry->vmid,
- __entry->vm_hub,__entry->pd_addr)
+ __entry->vm_hub, __entry->pd_addr)
);

DECLARE_EVENT_CLASS(amdgpu_pasid,
@@ -494,7 +494,7 @@ TRACE_EVENT(amdgpu_cs_bo_status,
);

TRACE_EVENT(amdgpu_bo_move,
- TP_PROTO(struct amdgpu_bo* bo, uint32_t new_placement, uint32_t old_placement),
+ TP_PROTO(struct amdgpu_bo *bo, uint32_t new_placement, uint32_t old_placement),
TP_ARGS(bo, new_placement, old_placement),
TP_STRUCT__entry(
__field(struct amdgpu_bo *, bo)
--
2.17.1

2023-08-07 18:38:20

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: Clean up errors in amdgpu_trace.h

Applied. Thanks!

On Wed, Aug 2, 2023 at 3:26 AM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required after that ',' (ctx:VxV)
> ERROR: "foo* bar" should be "foo *bar"
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> index 525dffbe046a..2fd1bfb35916 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h
> @@ -432,7 +432,7 @@ TRACE_EVENT(amdgpu_vm_flush,
> ),
> TP_printk("ring=%s, id=%u, hub=%u, pd_addr=%010Lx",
> __get_str(ring), __entry->vmid,
> - __entry->vm_hub,__entry->pd_addr)
> + __entry->vm_hub, __entry->pd_addr)
> );
>
> DECLARE_EVENT_CLASS(amdgpu_pasid,
> @@ -494,7 +494,7 @@ TRACE_EVENT(amdgpu_cs_bo_status,
> );
>
> TRACE_EVENT(amdgpu_bo_move,
> - TP_PROTO(struct amdgpu_bo* bo, uint32_t new_placement, uint32_t old_placement),
> + TP_PROTO(struct amdgpu_bo *bo, uint32_t new_placement, uint32_t old_placement),
> TP_ARGS(bo, new_placement, old_placement),
> TP_STRUCT__entry(
> __field(struct amdgpu_bo *, bo)
> --
> 2.17.1
>