2023-08-01 18:56:52

by Luis Chamberlain

[permalink] [raw]
Subject: Re: require EXPORT_SYMBOL_GPL symbols for symbol_get v2

On Tue, Aug 01, 2023 at 07:35:39PM +0200, Christoph Hellwig wrote:
> Hi all,
>
> this series changes symbol_get to only work on EXPORT_SYMBOL_GPL
> as nvidia is abusing the lack of this check to bypass restrictions
> on importing symbols from proprietary modules.

Reviewed-by: Luis Chamberlain <[email protected]>

Let me know if you want this to go through the modules tree or your own.

Luis



2023-08-02 13:38:46

by Christoph Hellwig

[permalink] [raw]
Subject: Re: require EXPORT_SYMBOL_GPL symbols for symbol_get v2

On Tue, Aug 01, 2023 at 10:45:34AM -0700, Luis Chamberlain wrote:
> On Tue, Aug 01, 2023 at 07:35:39PM +0200, Christoph Hellwig wrote:
> > Hi all,
> >
> > this series changes symbol_get to only work on EXPORT_SYMBOL_GPL
> > as nvidia is abusing the lack of this check to bypass restrictions
> > on importing symbols from proprietary modules.
>
> Reviewed-by: Luis Chamberlain <[email protected]>
>
> Let me know if you want this to go through the modules tree or your own.

I don't think this would fit anywhere but the modules tree.

Let me know if you want me to resend for the mmc dependency fixup or
if you want to squash it yourself.


2023-08-02 18:40:01

by Luis Chamberlain

[permalink] [raw]
Subject: Re: require EXPORT_SYMBOL_GPL symbols for symbol_get v2

On Wed, Aug 02, 2023 at 01:56:58PM +0200, Christoph Hellwig wrote:
> On Tue, Aug 01, 2023 at 10:45:34AM -0700, Luis Chamberlain wrote:
> > On Tue, Aug 01, 2023 at 07:35:39PM +0200, Christoph Hellwig wrote:
> > > Hi all,
> > >
> > > this series changes symbol_get to only work on EXPORT_SYMBOL_GPL
> > > as nvidia is abusing the lack of this check to bypass restrictions
> > > on importing symbols from proprietary modules.
> >
> > Reviewed-by: Luis Chamberlain <[email protected]>
> >
> > Let me know if you want this to go through the modules tree or your own.
>
> I don't think this would fit anywhere but the modules tree.

OK sure!

> Let me know if you want me to resend for the mmc dependency fixup or
> if you want to squash it yourself.

Applied, I squashed the depends on MMC=y as suggested by Arnd and pushed
out to modules-next.`

Luis