2023-08-02 13:33:26

by Ze Gao

[permalink] [raw]
Subject: [RFC PATCH v4 1/7] libtraceevent: sync state char array with the kernel

Update state char array to match the latest kernel
definitions.

Signed-off-by: Ze Gao <[email protected]>
---
plugins/plugin_sched_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/plugin_sched_switch.c b/plugins/plugin_sched_switch.c
index 8752cae..e0986ac 100644
--- a/plugins/plugin_sched_switch.c
+++ b/plugins/plugin_sched_switch.c
@@ -11,7 +11,7 @@

static void write_state(struct trace_seq *s, int val)
{
- const char states[] = "SDTtZXxW";
+ const char states[] = "SDTtXZPI";
int found = 0;
int i;

--
2.41.0



2023-08-02 15:03:05

by Steven Rostedt

[permalink] [raw]
Subject: Re: [RFC PATCH v4 1/7] libtraceevent: sync state char array with the kernel

On Wed, 2 Aug 2023 08:09:56 -0400
Ze Gao <[email protected]> wrote:

> Update state char array to match the latest kernel
> definitions.

Can you send this separately to [email protected]?

Thanks,

-- Steve

>
> Signed-off-by: Ze Gao <[email protected]>
> ---
> plugins/plugin_sched_switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/plugin_sched_switch.c b/plugins/plugin_sched_switch.c
> index 8752cae..e0986ac 100644
> --- a/plugins/plugin_sched_switch.c
> +++ b/plugins/plugin_sched_switch.c
> @@ -11,7 +11,7 @@
>
> static void write_state(struct trace_seq *s, int val)
> {
> - const char states[] = "SDTtZXxW";
> + const char states[] = "SDTtXZPI";
> int found = 0;
> int i;
>


2023-08-03 03:08:55

by Ze Gao

[permalink] [raw]
Subject: Re: [RFC PATCH v4 1/7] libtraceevent: sync state char array with the kernel

FYI, I‘ve already cc-ed to it. Do you mean I need to resend this patch
to [email protected] solely and exclude this one from
this series?

Regards,
Ze

On Wed, Aug 2, 2023 at 10:36 PM Steven Rostedt <[email protected]> wrote:
>
> On Wed, 2 Aug 2023 08:09:56 -0400
> Ze Gao <[email protected]> wrote:
>
> > Update state char array to match the latest kernel
> > definitions.
>
> Can you send this separately to [email protected]?
>
> Thanks,
>
> -- Steve
>
> >
> > Signed-off-by: Ze Gao <[email protected]>
> > ---
> > plugins/plugin_sched_switch.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/plugins/plugin_sched_switch.c b/plugins/plugin_sched_switch.c
> > index 8752cae..e0986ac 100644
> > --- a/plugins/plugin_sched_switch.c
> > +++ b/plugins/plugin_sched_switch.c
> > @@ -11,7 +11,7 @@
> >
> > static void write_state(struct trace_seq *s, int val)
> > {
> > - const char states[] = "SDTtZXxW";
> > + const char states[] = "SDTtXZPI";
> > int found = 0;
> > int i;
> >
>

2023-08-03 03:11:59

by Steven Rostedt

[permalink] [raw]
Subject: Re: [RFC PATCH v4 1/7] libtraceevent: sync state char array with the kernel

On Thu, 3 Aug 2023 10:13:16 +0800
Ze Gao <[email protected]> wrote:

> FYI, I‘ve already cc-ed to it. Do you mean I need to resend this patch
> to [email protected] solely and exclude this one from
> this series?
>

I searched the Cc list and missed it. Anyway, you only need to Cc the
patches that touch libtracevent, and not the rest. No biggy, I just have to
mark them as "Handled elsewhere" in patchwork.

-- Steve

2023-08-03 03:17:51

by Ze Gao

[permalink] [raw]
Subject: Re: [RFC PATCH v4 1/7] libtraceevent: sync state char array with the kernel

Got it. Will send patches for libtraceevent separately, Combining
patches from 2 different trees annoys me as well ;)

Regards,
Ze

On Thu, Aug 3, 2023 at 10:37 AM Steven Rostedt <[email protected]> wrote:
>
> On Thu, 3 Aug 2023 10:13:16 +0800
> Ze Gao <[email protected]> wrote:
>
> > FYI, I‘ve already cc-ed to it. Do you mean I need to resend this patch
> > to [email protected] solely and exclude this one from
> > this series?
> >
>
> I searched the Cc list and missed it. Anyway, you only need to Cc the
> patches that touch libtracevent, and not the rest. No biggy, I just have to
> mark them as "Handled elsewhere" in patchwork.
>
> -- Steve