2023-08-02 13:56:53

by Yue Haibing

Subject: [PATCH -next] iommu/amd: Remove unsued extern declaration amd_iommu_init_hardware()

From: YueHaibing <[email protected]>

Commit 2c0ae1720c09 ("iommu/amd: Convert iommu initialization to state machine")
left behind this.

Signed-off-by: YueHaibing <[email protected]>
---
include/linux/amd-iommu.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/amd-iommu.h b/include/linux/amd-iommu.h
index 953e6f12fa1c..99a5201d9e62 100644
--- a/include/linux/amd-iommu.h
+++ b/include/linux/amd-iommu.h
@@ -32,7 +32,6 @@ struct task_struct;
struct pci_dev;

extern int amd_iommu_detect(void);
-extern int amd_iommu_init_hardware(void);

/**
* amd_iommu_init_device() - Init device for use with IOMMUv2 driver
--
2.34.1

2023-08-02 19:09:01

by Suravee Suthikulpanit

Subject: Re: [PATCH -next] iommu/amd: Remove unsued extern declaration amd_iommu_init_hardware()

On 8/2/2023 6:32 AM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Commit 2c0ae1720c09 ("iommu/amd: Convert iommu initialization to state machine")
> left behind this.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> include/linux/amd-iommu.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/amd-iommu.h b/include/linux/amd-iommu.h
> index 953e6f12fa1c..99a5201d9e62 100644
> --- a/include/linux/amd-iommu.h
> +++ b/include/linux/amd-iommu.h
> @@ -32,7 +32,6 @@ struct task_struct;
> struct pci_dev;
>
> extern int amd_iommu_detect(void);
> -extern int amd_iommu_init_hardware(void);
>
> /**
> * amd_iommu_init_device() - Init device for use with IOMMUv2 driver

Reviewed-by: Suravee Suthikulpanit <[email protected]>

Thanks,
Suravee

2023-08-07 13:25:52

by Joerg Roedel

Subject: Re: [PATCH -next] iommu/amd: Remove unsued extern declaration amd_iommu_init_hardware()

On Wed, Aug 02, 2023 at 09:32:01PM +0800, Yue Haibing wrote:
> include/linux/amd-iommu.h | 1 -
> 1 file changed, 1 deletion(-)

Applied, thanks.