2023-08-03 03:27:54

by Meng, Li (Jassmine)

Subject: [PATCH V2] cpufreq: amd-pstate-ut: Modify the function to get the highest_perf value

The previous function amd_get_highest_perf() will be deprecated.
It can only return 166 or 255 by cpuinfo. For platforms that
support preferred core, the value of highest perf can be between
166 and 255. Therefore, it will cause amd-pstate-ut to fail when
run amd_pstate_ut_check_perf().

Signed-off-by: Meng Li <[email protected]>
---
drivers/cpufreq/amd-pstate-ut.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
index 7f3fe2048981..9c889a4a0177 100644
--- a/drivers/cpufreq/amd-pstate-ut.c
+++ b/drivers/cpufreq/amd-pstate-ut.c
@@ -145,8 +145,6 @@ static void amd_pstate_ut_check_perf(u32 index)
struct cpufreq_policy *policy = NULL;
struct amd_cpudata *cpudata = NULL;

- highest_perf = amd_get_highest_perf();
-
for_each_possible_cpu(cpu) {
policy = cpufreq_cpu_get(cpu);
if (!policy)
@@ -161,6 +159,7 @@ static void amd_pstate_ut_check_perf(u32 index)
return;
}

+ highest_perf = cppc_perf.highest_perf;
nominal_perf = cppc_perf.nominal_perf;
lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
lowest_perf = cppc_perf.lowest_perf;
@@ -172,6 +171,7 @@ static void amd_pstate_ut_check_perf(u32 index)
return;
}

+ highest_perf = AMD_CPPC_HIGHEST_PERF(cap1);
nominal_perf = AMD_CPPC_NOMINAL_PERF(cap1);
lowest_nonlinear_perf = AMD_CPPC_LOWNONLIN_PERF(cap1);
lowest_perf = AMD_CPPC_LOWEST_PERF(cap1);
--
2.34.1

2023-08-11 08:31:43

by Viresh Kumar

Subject: Re: [PATCH V2] cpufreq: amd-pstate-ut: Modify the function to get the highest_perf value

On 03-08-23, 09:43, Meng Li wrote:
> The previous function amd_get_highest_perf() will be deprecated.
> It can only return 166 or 255 by cpuinfo. For platforms that
> support preferred core, the value of highest perf can be between
> 166 and 255. Therefore, it will cause amd-pstate-ut to fail when
> run amd_pstate_ut_check_perf().
>
> Signed-off-by: Meng Li <[email protected]>
> ---
> drivers/cpufreq/amd-pstate-ut.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied. Thanks.

--
viresh

2023-08-11 09:32:10

by Rafael J. Wysocki

Subject: Re: [PATCH V2] cpufreq: amd-pstate-ut: Modify the function to get the highest_perf value

On Fri, Aug 11, 2023 at 8:17 AM Viresh Kumar <[email protected]> wrote:
>
> On 03-08-23, 09:43, Meng Li wrote:
> > The previous function amd_get_highest_perf() will be deprecated.
> > It can only return 166 or 255 by cpuinfo. For platforms that
> > support preferred core, the value of highest perf can be between
> > 166 and 255. Therefore, it will cause amd-pstate-ut to fail when
> > run amd_pstate_ut_check_perf().
> >
> > Signed-off-by: Meng Li <[email protected]>
> > ---
> > drivers/cpufreq/amd-pstate-ut.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied. Thanks.

So may I leave all of the amd-pstate patches to you?

I would gladly do that. :-)