2023-08-03 12:31:16

by Miaohe Lin

[permalink] [raw]
Subject: [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()

The correct function name is obj_cgroup_may_zswap(). Correct the comment.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 1ff51d8df84a..a026058ac720 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -7786,7 +7786,7 @@ bool obj_cgroup_may_zswap(struct obj_cgroup *objcg)
* @objcg: the object cgroup
* @size: size of compressed object
*
- * This forces the charge after obj_cgroup_may_swap() allowed
+ * This forces the charge after obj_cgroup_may_zswap() allowed
* compression and storage in zwap for this cgroup to go ahead.
*/
void obj_cgroup_charge_zswap(struct obj_cgroup *objcg, size_t size)
--
2.33.0



2023-08-03 16:11:49

by Johannes Weiner

[permalink] [raw]
Subject: Re: [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()

On Thu, Aug 03, 2023 at 08:00:21PM +0800, Miaohe Lin wrote:
> The correct function name is obj_cgroup_may_zswap(). Correct the comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Acked-by: Johannes Weiner <[email protected]>

2023-08-04 07:51:36

by Muchun Song

[permalink] [raw]
Subject: Re: [PATCH] mm/memcg: fix wrong function name above obj_cgroup_charge_zswap()



> On Aug 3, 2023, at 20:00, Miaohe Lin <[email protected]> wrote:
>
> The correct function name is obj_cgroup_may_zswap(). Correct the comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

Thanks.