2023-08-02 22:29:19

by Martin Botka

Subject: [PATCH v1 2/6] dt-bindings: arm: sunxi: Add BigTreeTech CB1

From: Martin Botka <[email protected]>

Add a name & compatible for BigTreeTech CB1 SoM

Signed-off-by: Martin Botka <[email protected]>
---
Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index ee8fdd2da869..5ae1b81af6fc 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -151,6 +151,11 @@ properties:
- const: roofull,beelink-x2
- const: allwinner,sun8i-h3

+ - description: BigTreeTech CB1 SoM
+ items:
+ - const: bigtreetech,cb1
+ - const: allwinner,sun50i-h616
+
- description: Chuwi V7 CW0825
items:
- const: chuwi,v7-cw0825
--
2.41.0

2023-08-03 13:05:06

by Andre Przywara

Subject: Re: [PATCH v1 2/6] dt-bindings: arm: sunxi: Add BigTreeTech CB1

On Thu, 3 Aug 2023 00:02:35 +0200
Martin Botka <[email protected]> wrote:

Hi,

> From: Martin Botka <[email protected]>
>
> Add a name & compatible for BigTreeTech CB1 SoM
>
> Signed-off-by: Martin Botka <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index ee8fdd2da869..5ae1b81af6fc 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -151,6 +151,11 @@ properties:
> - const: roofull,beelink-x2
> - const: allwinner,sun8i-h3
>
> + - description: BigTreeTech CB1 SoM
> + items:
> + - const: bigtreetech,cb1
> + - const: allwinner,sun50i-h616
> +

If I get this correctly, the CB1 is the SoM, which cannot be used on its
own, right? In this case there is no need for an entry in this file, since
this combination will never appear in a board .dts file alone.
So just drop this patch then.

Cheers,
Andre

> - description: Chuwi V7 CW0825
> items:
> - const: chuwi,v7-cw0825