2023-08-03 12:08:50

by Miaohe Lin

Subject: [PATCH] cgroup: fix obsolete function name in cgroup_destroy_locked()

Since commit e76ecaeef65c ("cgroup: use cgroup_kn_lock_live() in other
cgroup kernfs methods"), cgroup_kn_lock_live() is used in cgroup kernfs
methods. Update corresponding comment.

Signed-off-by: Miaohe Lin <[email protected]>
---
kernel/cgroup/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index d620d7ec47e8..f230446598ac 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -5871,7 +5871,7 @@ static int cgroup_destroy_locked(struct cgroup *cgrp)
/*
* Mark @cgrp and the associated csets dead. The former prevents
* further task migration and child creation by disabling
- * cgroup_lock_live_group(). The latter makes the csets ignored by
+ * cgroup_kn_lock_live(). The latter makes the csets ignored by
* the migration path.
*/
cgrp->self.flags &= ~CSS_ONLINE;
--
2.33.0

2023-08-03 15:43:39

by Johannes Weiner

Subject: Re: [PATCH] cgroup: fix obsolete function name in cgroup_destroy_locked()

On Thu, Aug 03, 2023 at 07:57:02PM +0800, Miaohe Lin wrote:
> Since commit e76ecaeef65c ("cgroup: use cgroup_kn_lock_live() in other
> cgroup kernfs methods"), cgroup_kn_lock_live() is used in cgroup kernfs
> methods. Update corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Acked-by: Johannes Weiner <[email protected]>