2023-08-03 22:53:14

by Fabio Estevam

[permalink] [raw]
Subject: [PATCH 1/2] ASoC: dt-bindings: wlf,wm8960: Describe the power supplies

From: Fabio Estevam <[email protected]>

WM8960 has the following power supplies:

- AVDD
- DBVDD
- DCVDD
- SPKVDD1
- SPKVDD1

Add them to bindings to improve the hardware description.

Signed-off-by: Fabio Estevam <[email protected]>
---
.../devicetree/bindings/sound/wlf,wm8960.yaml | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8960.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8960.yaml
index ee8eba7f0104..82519f6720ef 100644
--- a/Documentation/devicetree/bindings/sound/wlf,wm8960.yaml
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8960.yaml
@@ -26,6 +26,21 @@ properties:
'#sound-dai-cells':
const: 0

+ AVDD-supply:
+ description: Analogue supply.
+
+ DBVDD-supply:
+ description: Digital Buffer Supply.
+
+ DCVDD-supply:
+ description: Digital Core Supply.
+
+ SPKVDD1-supply:
+ description: Supply for speaker drivers 1.
+
+ SPKVDD2-supply:
+ description: Supply for speaker drivers 2.
+
wlf,capless:
type: boolean
description:
@@ -84,5 +99,10 @@ examples:
wlf,hp-cfg = <3 2 3>;
wlf,gpio-cfg = <1 3>;
wlf,shared-lrclk;
+ DCVDD-supply = <&reg_audio>;
+ DBVDD-supply = <&reg_audio>;
+ AVDD-supply = <&reg_audio>;
+ SPKVDD1-supply = <&reg_audio>;
+ SPKVDD2-supply = <&reg_audio>;
};
};
--
2.34.1



2023-08-04 09:57:15

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: wlf,wm8960: Describe the power supplies

On Thu, Aug 03, 2023 at 06:55:05PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> WM8960 has the following power supplies:
>
> - AVDD
> - DBVDD
> - DCVDD
> - SPKVDD1
> - SPKVDD1
>
> Add them to bindings to improve the hardware description.
>
> Signed-off-by: Fabio Estevam <[email protected]>
> ---

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2023-08-04 16:25:52

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: wlf,wm8960: Describe the power supplies

On Thu, Aug 03, 2023 at 06:55:05PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> WM8960 has the following power supplies:
>
> - AVDD
> - DBVDD
> - DCVDD
> - SPKVDD1
> - SPKVDD1
>
> Add them to bindings to improve the hardware description.
>
> Signed-off-by: Fabio Estevam <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Thanks,
Conor.


Attachments:
(No filename) (410.00 B)
signature.asc (235.00 B)
Download all attachments

2023-08-04 18:02:27

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: wlf,wm8960: Describe the power supplies

On Thu, 03 Aug 2023 18:55:05 -0300, Fabio Estevam wrote:
> WM8960 has the following power supplies:
>
> - AVDD
> - DBVDD
> - DCVDD
> - SPKVDD1
> - SPKVDD1
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: dt-bindings: wlf,wm8960: Describe the power supplies
commit: 6a41c3a1606089bdf7f8da2b267d1d82fb32b378
[2/2] ASoC: wm8960: Add support for the power supplies
commit: 422f10adc3eb5a7ff8567bf6e6590a4e4fa756c3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


2023-08-05 22:44:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: wlf,wm8960: Describe the power supplies

On 03/08/2023 23:55, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> WM8960 has the following power supplies:
>
> - AVDD
> - DBVDD
> - DCVDD
> - SPKVDD1
> - SPKVDD1
>
> Add them to bindings to improve the hardware description.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by
automated tooling. Performing review on untested code might be a waste
of time, thus I will skip this patch entirely till you follow the
process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof