2023-08-04 03:55:16

by zhangqing

[permalink] [raw]

Subject: [RESEND PATCH v3 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

---

add PCLK_VO1GRF clk id.

Signed-off-by: Elaine Zhang <[email protected]>
---
include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
index b5616bca7b44..864a321ab362 100644
--- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
+++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
@@ -733,8 +733,9 @@
#define ACLK_AV1_PRE 718
#define PCLK_AV1_PRE 719
#define HCLK_SDIO_PRE 720
+#define PCLK_VO1GRF 721

-#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1)
+#define CLK_NR_CLKS (PCLK_VO1GRF + 1)

/* scmi-clocks indices */

--
2.17.1

2023-08-04 16:38:42

by Conor Dooley

[permalink] [raw]

Subject: Re: [RESEND PATCH v3 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

---

On Fri, Aug 04, 2023 at 10:51:01AM +0800, Elaine Zhang wrote:
> add PCLK_VO1GRF clk id.
>
> Signed-off-by: Elaine Zhang <[email protected]>
> ---
> include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index b5616bca7b44..864a321ab362 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -733,8 +733,9 @@
> #define ACLK_AV1_PRE 718
> #define PCLK_AV1_PRE 719
> #define HCLK_SDIO_PRE 720
> +#define PCLK_VO1GRF 721
>
> -#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1)
> +#define CLK_NR_CLKS (PCLK_VO1GRF + 1)

I only got this patch & not the rest of the series, so no idea what's
going in those patches, but since CLK_NR_CLKS was put in a dt-binding
header, is that value not now part of the ABI?

Thanks,
Conor.

>
> /* scmi-clocks indices */
>
> --
> 2.17.1
>

---

Attachments:

(No filename) (1.04 kB)
signature.asc (235.00 B)
Download all attachments

2023-08-07 08:56:41

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [RESEND PATCH v3 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

---

On 04/08/2023 17:38, Conor Dooley wrote:
> On Fri, Aug 04, 2023 at 10:51:01AM +0800, Elaine Zhang wrote:
>> add PCLK_VO1GRF clk id.
>>
>> Signed-off-by: Elaine Zhang <[email protected]>
>> ---
>> include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
>> index b5616bca7b44..864a321ab362 100644
>> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
>> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
>> @@ -733,8 +733,9 @@
>> #define ACLK_AV1_PRE 718
>> #define PCLK_AV1_PRE 719
>> #define HCLK_SDIO_PRE 720
>> +#define PCLK_VO1GRF 721
>>
>> -#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1)
>> +#define CLK_NR_CLKS (PCLK_VO1GRF + 1)
>
> I only got this patch & not the rest of the series, so no idea what's
> going in those patches, but since CLK_NR_CLKS was put in a dt-binding
> header, is that value not now part of the ABI?

Technically yes, practically does not matter because no one should use
it. More bindings make the same mistakes, so it could be just dropped.

Best regards,
Krzysztof