2023-08-04 10:50:19

by Sudeep Holla

[permalink] [raw]
Subject: Re: [PATCH v2 17/23] firmware: Explicitly include correct DT includes

On Thu, Aug 03, 2023 at 04:42:57PM -0600, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Acked-by: Dinh Nguyen <[email protected]>
> Acked-by: Thierry Reding <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> drivers/firmware/arm_scmi/driver.c | 4 ++--
> drivers/firmware/scpi_pm_domain.c | 3 ++-

(For SCMI changes)

Acked-by: Sudeep Holla <[email protected]>

--
Regards,
Sudeep